Bug 64231 - Generate conditional include statements in CodeGeneratorJS
Summary: Generate conditional include statements in CodeGeneratorJS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 64960 64961 65040
  Show dependency tree / graph
 
Reported: 2011-07-09 10:45 PDT by Patrick R. Gansterer
Modified: 2011-07-22 12:32 PDT (History)
0 users

See Also:

Attachments
Patch (4.76 KB, patch)
2011-07-09 11:04 PDT, Patrick R. Gansterer 		bfulgham: review+
paroga: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-07-09 10:45:48 PDT 
Generate conditional include statements in CodeGeneratorJS
Comment 1 Patrick R. Gansterer 2011-07-09 11:04:30 PDT 
Created attachment 100210 [details]
Patch
Comment 2 Brent Fulgham 2011-07-10 18:57:31 PDT 
Comment on attachment 100210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review

Great idea!  I have a question (inline), but otherwise looks good.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948
> +        foreach my $include (sort keys %implIncludes) {

We didn't sort these keys previously.  Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output?
Comment 3 Patrick R. Gansterer 2011-07-10 22:08:33 PDT 
Comment on attachment 100210 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100210&action=review

>> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2948
>> +        foreach my $include (sort keys %implIncludes) {
> 
> We didn't sort these keys previously.  Is the sorting just for legibility in the output? Or is it necessary to get proper function in generating the conditionalized output?

Uhh, it's a relict of a temporary change. I'll remove it.
Comment 4 Patrick R. Gansterer 2011-07-10 22:20:17 PDT 
Committed r90717: <http://trac.webkit.org/changeset/90717>