Bug 64859 – SVGAnimation does not support 'values' for from-to animations

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

SVGAnimation does not support 'values' for from-to animations.

[Young Han Lee]

The title of this bug seems a little confusing since the test indicated by the URL doesn't have a 'values' in their animation.

This is rather a bug about supporting 'keyTimes' for from-to animations.

[Young Han Lee]

Created attachment 107183 [details]
Patch

[Young Han Lee]

This is a patch for discussion (can be applied).

I'm not sure if the patch have to include the W3C test.

[Dirk Schulze]

Comment on attachment 107183 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107183&action=review

> Source/WebCore/svg/SVGAnimationElement.cpp:468
> +    if (calcMode() == CalcModeDiscrete && m_keyTimes.size() == 2)
> +        return percent > m_keyTimes[1] ? 1 : 0;

... and what about none discrete animations? Don't we need to calculate the values as well?

[Young Han Lee]

1. "Specifying a from value and a to value defines a simple animation, equivalent to a values list with 2 values."[1]

2. "For linear and spline animation, the first time value in the list must be 0, and the last time value in the list must be 1"[2]

Thus, in the case of from-to animation, keyTimes should be "0;1" if the calculation mode is not discrete. So we can ignore it.


[1] http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncValues
[2] http://www.w3.org/TR/SVG/animate.html#ValueAttributes

[Dirk Schulze]

Comment on attachment 107183 [details]
Patch

Thank you for the explanation! Great patch! r=me.

[WebKit Review Bot]

Comment on attachment 107183 [details]
Patch

Rejecting attachment 107183 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
o-playing-and-pause.html = MISSING PASS


Regressions: Unexpected image and text mismatch : (1)
  svg/custom/svg-fonts-word-spacing.html = IMAGE+TEXT

Regressions: Unexpected image mismatch : (5)
  fast/text/atsui-multiple-renderers.html = IMAGE
  fast/text/international/danda-space.html = IMAGE
  fast/text/international/thai-baht-space.html = IMAGE
  fast/text/international/thai-line-breaks.html = IMAGE
  platform/chromium-linux/fast/text/international/complex-joining-using-gpos.html = IMAGE



Full output: http://queues.webkit.org/results/9820140

[Young Han Lee]

It seems that the commit process failed because of some other reason, not my patch.

Would you commit+ again, Dirk?

[WebKit Review Bot]

Comment on attachment 107183 [details]
Patch

Clearing flags on attachment: 107183

Committed r95907: <http://trac.webkit.org/changeset/95907>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.