Bug 64611 - Find indicator should take scale factor into account
Summary: Find indicator should take scale factor into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-07-15 11:49 PDT by Anders Carlsson
Modified: 2011-07-16 21:31 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.05 KB, patch)
2011-07-15 11:51 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-07-15 11:49:25 PDT
Find indicator should take scale factor into account
Comment 1 Anders Carlsson 2011-07-15 11:51:49 PDT
Created attachment 101016 [details]
Patch
Comment 2 Anders Carlsson 2011-07-15 12:10:59 PDT
Committed r91085: <http://trac.webkit.org/changeset/91085>
Comment 3 Darin Adler 2011-07-15 16:55:11 PDT
<rdar://problem/9709365>
Comment 4 Daniel Bates 2011-07-16 21:31:41 PDT
For reference, this change broke the Qt Linux Release bot since it made use of the scale factor overloaded ShareableBitmap::paint() method (implemented for CG in <http://trac.webkit.org/changeset/90198>).

Qt Linux Release bot stdio: <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/35470/steps/compile-webkit/logs/stdio>

I committed a stub implementation for the Qt WebKit2 port in <http://trac.webkit.org/changeset/91162>. See bug #64663 for more details.

Other WebKit2 ports are most likely also affected by the lack of an implementation for the scale factor variant of ShareableBitmap::paint(). Will file bugs for these ports and land stub implementations for now.