RESOLVED FIXED 64605
Move expectation parsing code to TestExpectationsParser. 
https://bugs.webkit.org/show_bug.cgi?id=64605
Summary Move expectation parsing code to TestExpectationsParser.
Dimitri Glazkov (Google)
Reported 2011-07-15 10:58:22 PDT
Move expectation parsing code to TestExpectationsParser.
Attachments
Patch (25.28 KB, patch)
2011-07-15 11:08 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-15 11:08:22 PDT
Created attachment 101004 [details] Patch
Adam Barth
Comment 2 2011-07-15 12:06:12 PDT
Comment on attachment 101004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101004&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:208 > + has_wontfix = 'wontfix' in expectation.modifiers Ojan would tell you to make 'wontfix' a string constant instead of a string literal. > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:210 > + for opt in expectation.modifiers: opt => option or modifier ?
Dimitri Glazkov (Google)
Comment 3 2011-07-15 12:33:22 PDT
Comment on attachment 101004 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=101004&action=review >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:208 >> + has_wontfix = 'wontfix' in expectation.modifiers > > Ojan would tell you to make 'wontfix' a string constant instead of a string literal. Yeah, I need to do a quick code bath to remove all these. >> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:210 >> + for opt in expectation.modifiers: > > opt => option or modifier ? ditto.
Dimitri Glazkov (Google)
Comment 4 2011-07-15 12:33:56 PDT
Comment on attachment 101004 [details] Patch Clearing flags on attachment: 101004 Committed r91092: <http://trac.webkit.org/changeset/91092>
Dimitri Glazkov (Google)
Comment 5 2011-07-15 12:34:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.