Bug 64605 - Move expectation parsing code to TestExpectationsParser.
Summary: Move expectation parsing code to TestExpectationsParser.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 64602
Blocks: 64385
  Show dependency tree / graph
 
Reported: 2011-07-15 10:58 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-15 12:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (25.28 KB, patch)
2011-07-15 11:08 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-15 10:58:22 PDT 
Move expectation parsing code to TestExpectationsParser.
Comment 1 Dimitri Glazkov (Google) 2011-07-15 11:08:22 PDT 
Created attachment 101004 [details]
Patch
Comment 2 Adam Barth 2011-07-15 12:06:12 PDT 
Comment on attachment 101004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101004&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:208
> +        has_wontfix = 'wontfix' in expectation.modifiers

Ojan would tell you to make 'wontfix' a string constant instead of a string literal.

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:210
> +        for opt in expectation.modifiers:

opt => option or modifier ?
Comment 3 Dimitri Glazkov (Google) 2011-07-15 12:33:22 PDT 
Comment on attachment 101004 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101004&action=review

>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:208
>> +        has_wontfix = 'wontfix' in expectation.modifiers
> 
> Ojan would tell you to make 'wontfix' a string constant instead of a string literal.

Yeah, I need to do a quick code bath to remove all these.

>> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:210
>> +        for opt in expectation.modifiers:
> 
> opt => option or modifier ?

ditto.
Comment 4 Dimitri Glazkov (Google) 2011-07-15 12:33:56 PDT 
Comment on attachment 101004 [details]
Patch

Clearing flags on attachment: 101004

Committed r91092: <http://trac.webkit.org/changeset/91092>
Comment 5 Dimitri Glazkov (Google) 2011-07-15 12:34:01 PDT 
All reviewed patches have been landed.  Closing bug.