RESOLVED FIXED 64602
Switch to use Python enumerate function to enumerate line numbers. 
https://bugs.webkit.org/show_bug.cgi?id=64602
Summary Switch to use Python enumerate function to enumerate line numbers.
Dimitri Glazkov (Google)
Reported 2011-07-15 09:32:19 PDT
Switch to use Python enumerate function to enumerate line numbers.
Attachments
Patch (2.03 KB, patch)
2011-07-15 09:32 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-15 09:32:52 PDT
Created attachment 100994 [details] Patch
Adam Barth
Comment 2 2011-07-15 12:01:23 PDT
Comment on attachment 100994 [details] Patch Is this correctly one/zero based? Looks like the old code was 1-based but I would have expected enumerate to be 0-based.
Dimitri Glazkov (Google)
Comment 3 2011-07-15 12:29:07 PDT
(In reply to comment #2) > (From update of attachment 100994 [details]) > Is this correctly one/zero based? Looks like the old code was 1-based but I would have expected enumerate to be 0-based. enumerate is indeed 0-based. That's why I have the start=1 parameter.
Dimitri Glazkov (Google)
Comment 4 2011-07-15 12:29:49 PDT
Comment on attachment 100994 [details] Patch Clearing flags on attachment: 100994 Committed r91091: <http://trac.webkit.org/changeset/91091>
Dimitri Glazkov (Google)
Comment 5 2011-07-15 12:29:54 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 6 2011-07-15 12:53:49 PDT
Comment on attachment 100994 [details] Patch Ok. I'm blind.
Dimitri Glazkov (Google)
Comment 7 2011-07-15 13:50:34 PDT
Reverted in http://trac.webkit.org/changeset/91106, after breaking lotsa tests on Leopard.
Note You need to log in before you can comment on or make changes to this bug.