Bug 64492 – NRWT doesn't store the svn revision in full_results.json on chromium-win

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[WebKit Review Bot]

NRWT doesn't store the svn revision in full_results.json on chromium-win
Requested by abarth on #webkit.

[Eric Seidel (no email)]

I suspect that the output of "svn info" is different on windows.

If someone could post the output of svn info from their windows box (run inside a webkit checkout), that would be most helpful!

[Eric Seidel (no email)]

I think ChromiumWin uses win32 instead of CYGWIN, right?  That may be the difference.  We may not be prepared for whatever svn info looks like with windows svn.

[Ojan Vafai]

Hmmm...we're able to get the revision number for incremental_results.json...wonder what we do differently there.

[Tony Chang]

D:\src\WebKit-svn>svn --version
svn, version 1.6.6 (r40053)
   compiled Oct 19 2009, 09:36:48

Copyright (C) 2000-2009 CollabNet.
Subversion is open source software, see http://subversion.tigris.org/
This product includes software developed by CollabNet (http://www.Collab.Net/).

The following repository access (RA) modules are available:

* ra_neon : Module for accessing a repository via WebDAV protocol using Neon.
  - handles 'http' scheme
  - handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network protocol.
  - with Cyrus SASL authentication
  - handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
  - handles 'file' scheme
* ra_serf : Module for accessing a repository via WebDAV protocol using serf.
  - handles 'http' scheme
  - handles 'https' scheme


D:\src\WebKit-svn>svn info
Path: .
URL: http://svn.webkit.org/repository/webkit/trunk
Repository Root: http://svn.webkit.org/repository/webkit
Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Revision: 82480
Node Kind: directory
Schedule: normal
Last Changed Author: [e-mail]
Last Changed Rev: 82480
Last Changed Date: 2011-03-30 11:50:19 -0700 (Wed, 30 Mar 2011)

[Eric Seidel (no email)]

Hmm... scm.default_scm().head_svn_revision() works fine on the (former) Windows EWS image on ec2.

[Eric Seidel (no email)]

To be clear, I believe this is the code which is failing on the cr-win bot:
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py#L211

[Eric Seidel (no email)]

Added some logging in http://trac.webkit.org/changeset/90977.

[Eric Seidel (no email)]

Created attachment 100839 [details]
Patch

[Ojan Vafai]

Comment on attachment 100839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100839&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:607
> +        # Config webkit_base_dir() knows where the webkit root is, no other

This is a bit confusing. I'd s/Config webkit_base_dir()/self._config.webkit_base_dir()/ just to be more clear.

[Eric Seidel (no email)]

Committed r91023: <http://trac.webkit.org/changeset/91023>

[Eric Seidel (no email)]

This appears to have caused 15 python tests to fail on the bots.

[Eric Seidel (no email)]

Created attachment 100861 [details]
Patch

[Eric Seidel (no email)]

I thought webkit-patch knew how to re-open bugs these days?  Maybe that patch never landed.

[Eric Seidel (no email)]

Committed r91028: <http://trac.webkit.org/changeset/91028>

[Daniel Bates]

Comment on attachment 100861 [details]
Patch

Clearing review and commit-queue flags since this patch was already landed.