Bug 64488 - Fix WTF header guard style check
Summary: Fix WTF header guard style check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ilya Sherman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-13 15:15 PDT by Ilya Sherman
Modified: 2011-07-13 16:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.23 KB, patch)
2011-07-13 15:15 PDT, Ilya Sherman
no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2011-07-13 16:18 PDT, Ilya Sherman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Sherman 2011-07-13 15:15:09 PDT
Fix WTF header guard style check
Comment 1 Ilya Sherman 2011-07-13 15:15:32 PDT
Created attachment 100719 [details]
Patch
Comment 2 David Levin 2011-07-13 15:25:39 PDT
Comment on attachment 100719 [details]
Patch

A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it).
Comment 3 Ilya Sherman 2011-07-13 16:18:19 PDT
Created attachment 100727 [details]
Patch
Comment 4 Ilya Sherman 2011-07-13 16:19:24 PDT
(In reply to comment #2)
> (From update of attachment 100719 [details])
> A test would be nice. I guess you ran this such that the filename was '/wtf/...' and the call should have been filename.find() >= 0 (or even better how you wrote it).

Added a test.  This was patch was originally motivated by a false-positive style warning for https://bugs.webkit.org/show_bug.cgi?id=64333
Comment 5 David Levin 2011-07-13 16:21:59 PDT
Comment on attachment 100727 [details]
Patch

Oh of course. Thanks!
Comment 6 WebKit Review Bot 2011-07-13 16:45:31 PDT
Comment on attachment 100727 [details]
Patch

Clearing flags on attachment: 100727

Committed r90965: <http://trac.webkit.org/changeset/90965>
Comment 7 WebKit Review Bot 2011-07-13 16:45:35 PDT
All reviewed patches have been landed.  Closing bug.