Bug 64333 - Rename AutoFill -> Autofill
Summary: Rename AutoFill -> Autofill
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ilya Sherman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 18:01 PDT by Ilya Sherman
Modified: 2011-07-14 09:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (28.74 KB, patch)
2011-07-11 18:04 PDT, Ilya Sherman 		fishd: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Full diff, I hope (76.02 KB, patch)
2011-07-12 17:23 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
patch (74.89 KB, patch)
2011-07-13 17:01 PDT, Ilya Sherman 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Sherman 2011-07-11 18:01:49 PDT 
Rename AutoFill -> Autofill
Comment 1 Ilya Sherman 2011-07-11 18:04:14 PDT 
Created attachment 100397 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-11 18:25:46 PDT 
Comment on attachment 100397 [details]
Patch

Attachment 100397 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9021003
Comment 3 WebKit Review Bot 2011-07-11 20:38:33 PDT 
Comment on attachment 100397 [details]
Patch

Attachment 100397 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9021035
Comment 4 Darin Fisher (:fishd, Google) 2011-07-12 10:18:04 PDT 
Comment on attachment 100397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review

> Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> +    if '/wtf/' in filename:

wait, is this change really intended to be part of this patch?
Comment 5 Ilya Sherman 2011-07-12 17:23:52 PDT 
Created attachment 100594 [details]
Full diff, I hope
Comment 6 Ilya Sherman 2011-07-12 17:27:19 PDT 
Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped.  Sorry for not noticing that sooner.

(In reply to comment #4)
> (From update of attachment 100397 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review
> 
> > Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> > +    if '/wtf/' in filename:
> 
> wait, is this change really intended to be part of this patch?

Yes.  I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect.
Comment 7 Darin Fisher (:fishd, Google) 2011-07-13 09:47:03 PDT 
(In reply to comment #6)
> Re-uploaded the patch by hand, including the renamed files that "webkit-patch upload" dropped.  Sorry for not noticing that sooner.
> 
> (In reply to comment #4)
> > (From update of attachment 100397 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=100397&action=review
> > 
> > > Tools/Scripts/webkitpy/style/checkers/cpp.py:926
> > > +    if '/wtf/' in filename:
> > 
> > wait, is this change really intended to be part of this patch?
> 
> Yes.  I can split this out to a separate patch if preferable; but the style checker was (incorrectly) complaining that the header guards in the renamed files were incorrect.

^^^ Yes, it is usually good to separate out separate issues into separate patches.  In this case, I'm not the best reviewer for anything under webkitpy, and the bugzilla does not make it easy to request review from multiple people.
Comment 8 Ilya Sherman 2011-07-13 17:01:49 PDT 
Created attachment 100732 [details]
patch

Split out the style checker change to a separate patch.
Comment 9 WebKit Review Bot 2011-07-14 09:43:05 PDT 
Comment on attachment 100732 [details]
patch

Clearing flags on attachment: 100732

Committed r91004: <http://trac.webkit.org/changeset/91004>
Comment 10 WebKit Review Bot 2011-07-14 09:43:10 PDT 
All reviewed patches have been landed.  Closing bug.