Bug 64413 - Rename FloatRect/Point/Size and move them to an abstraction
Summary: Rename FloatRect/Point/Size and move them to an abstraction
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on: 64754
Blocks: 63567 64405
  Show dependency treegraph
 
Reported: 2011-07-12 17:31 PDT by Levi Weintraub
Modified: 2011-11-01 17:05 PDT (History)
8 users (show)

See Also:


Attachments
Rev 1, Mac only (917.31 KB, patch)
2011-07-13 16:57 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Trying Again (969.98 KB, patch)
2011-07-13 17:06 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (1.80 MB, patch)
2011-07-14 14:21 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (1.80 MB, patch)
2011-07-14 14:42 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch (1.81 MB, patch)
2011-07-14 16:37 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-07-12 17:31:34 PDT
We may want to use something other than floats for the various graphics structures on different platforms -- namely CGFloat on Mac  -- so renaming the floating point graphics structures  to something more generic. I recommend "Graphics*": GraphicsUnit, GraphicsPoint, GraphicsSize, and GraphicsRect. Simon also recommended "Render*".
Comment 1 Simon Fraser (smfr) 2011-07-12 17:41:52 PDT
Graphics* works better for me.
Comment 2 Levi Weintraub 2011-07-12 19:57:44 PDT
(In reply to comment #1)
> Graphics* works better for me.

Agreed. Graphics it is -- it's more descriptive of the actual use.
Comment 3 Levi Weintraub 2011-07-13 16:57:08 PDT
Created attachment 100730 [details]
Rev 1, Mac only

Only changed the Mac platform so this patch isn't done, but it is absolutely massive... Simon, mind doing a sanity check?
Comment 4 Levi Weintraub 2011-07-13 17:06:28 PDT
Created attachment 100734 [details]
Trying Again

Forgot to add the new files.
Comment 5 Levi Weintraub 2011-07-14 14:21:14 PDT
Created attachment 100862 [details]
Patch
Comment 6 Levi Weintraub 2011-07-14 14:42:20 PDT
Created attachment 100866 [details]
Patch
Comment 7 Levi Weintraub 2011-07-14 14:42:52 PDT
Trying to get a patch to apply...
Comment 8 Levi Weintraub 2011-07-14 16:37:56 PDT
Created attachment 100894 [details]
Patch
Comment 9 Levi Weintraub 2011-07-14 16:39:28 PDT
One more try before changing tact.
Comment 10 Levi Weintraub 2011-07-15 10:55:38 PDT
Changing tact and landing in pieces with a typedef. This is just way too damn big. Sorry about the noise.