Bug 64288 - WebSocket: Remove WebSocket tests that do not apply to hybi protocol
Summary: WebSocket: Remove WebSocket tests that do not apply to hybi protocol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 50099
  Show dependency treegraph
 
Reported: 2011-07-11 09:20 PDT by Yuta Kitamura
Modified: 2011-07-11 18:26 PDT (History)
4 users (show)

See Also:


Attachments
Patch (28.32 KB, patch)
2011-07-11 10:24 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-11 09:20:31 PDT
Follow-up of bug 64242.
Comment 1 Yuta Kitamura 2011-07-11 10:24:24 PDT
Created attachment 100323 [details]
Patch
Comment 2 Kent Tamura 2011-07-11 18:09:44 PDT
Comment on attachment 100323 [details]
Patch

Copying everything then removing unnecessary tests wastes resources.  We should have copied only necessary tests.
Comment 3 WebKit Review Bot 2011-07-11 18:24:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 100323 [details]:

http/tests/misc/slow-loading-mask.html bug 64069 (author: bdakin@apple.com)
fast/blockflow/japanese-lr-selection.html bug 64264 (author: hyatt@apple.com)
fast/blockflow/japanese-rl-selection.html bug 64265 (author: hyatt@apple.com)
fast/events/event-attributes-after-exception.html bug 64335 (author: ggaren@apple.com)
fast/box-shadow/scaled-box-shadow.html bug 64266 (author: simon.fraser@apple.com)
fast/backgrounds/background-leakage.html bug 64267 (author: simon.fraser@apple.com)
fast/backgrounds/repeat/negative-offset-repeat.html bug 64268 (author: mitz@webkit.org)
transforms/2d/hindi-rotated.html bug 64269 (authors: darin@apple.com and jshin@chromium.org)
svg/repaint/filter-repaint.svg bug 64270 (author: krit@webkit.org)
svg/W3C-SVG-1.1/struct-use-01-t.svg bug 64271 (authors: darin@apple.com and eric@webkit.org)
svg/transforms/text-with-mask-with-svg-transform.svg bug 64272 (author: zimmermann@kde.org)
The commit-queue is continuing to process your patch.
Comment 4 WebKit Review Bot 2011-07-11 18:26:26 PDT
Comment on attachment 100323 [details]
Patch

Clearing flags on attachment: 100323

Committed r90801: <http://trac.webkit.org/changeset/90801>
Comment 5 WebKit Review Bot 2011-07-11 18:26:31 PDT
All reviewed patches have been landed.  Closing bug.