Bug 64242 - WebSocket: Copy existing WebSocket tests
Summary: WebSocket: Copy existing WebSocket tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 50099
  Show dependency tree / graph
 
Reported: 2011-07-10 11:35 PDT by Yuta Kitamura
Modified: 2011-07-11 00:51 PDT (History)
3 users (show)

See Also:

Attachments
Patch (233.78 KB, patch)
2011-07-10 11:53 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
Patch v2 (Put tests under hybi/) (215.52 KB, patch)
2011-07-10 23:15 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
Merge to trunk to see EWS results (215.53 KB, patch)
2011-07-10 23:48 PDT, Yuta Kitamura 		yutak: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-10 11:35:05 PDT 
To land the new WebSocket protocol implementation, we need to land existing tests under http/tests/websocket/tests and make them run correctly with the new protocol.

Necessary steps are:

(1) Copy existing WebSocket tests into http/tests/websocket/tests, and mark them as skipped.
(2) Fix the tests so they can be run with the new protocol. Some obsolete tests may be removed in this step.
(3) Land the new WebSocket protocol implementation, and unskip the tests.

This bug takes care of step (1).
Comment 1 Yuta Kitamura 2011-07-10 11:53:35 PDT 
Created attachment 100234 [details]
Patch
Comment 2 Yuta Kitamura 2011-07-10 11:54:34 PDT 
Comment on attachment 100234 [details]
Patch

This should be committed manually, so setting cq-.
Comment 3 Kent Tamura 2011-07-10 18:06:32 PDT 
Comment on attachment 100234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100234&action=review

> LayoutTests/platform/win/Skipped:1355
> +# Skipped until new WebSocket protocol is implemented. http://webkit.org/b/50099
> +http/tests/websocket/tests/alert-in-event-handler.html

I prefer copy the tests into a subdirectory such as http/tests/websocket/tets/hybi/, and skip the directory.
Yuta-san, what do you think?
Comment 4 Yuta Kitamura 2011-07-10 20:09:29 PDT 
Comment on attachment 100234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100234&action=review

>> LayoutTests/platform/win/Skipped:1355
>> +http/tests/websocket/tests/alert-in-event-handler.html
> 
> I prefer copy the tests into a subdirectory such as http/tests/websocket/tets/hybi/, and skip the directory.
> Yuta-san, what do you think?

Sure, that sounds better to me, too. I will update the patch.
Comment 5 Yuta Kitamura 2011-07-10 23:15:12 PDT 
Created attachment 100245 [details]
Patch v2 (Put tests under hybi/)
Comment 6 Kent Tamura 2011-07-10 23:32:51 PDT 
Comment on attachment 100245 [details]
Patch v2 (Put tests under hybi/)

ok
Comment 7 Yuta Kitamura 2011-07-10 23:48:06 PDT 
Created attachment 100246 [details]
Merge to trunk to see EWS results
Comment 8 Yuta Kitamura 2011-07-10 23:50:40 PDT 
Thanks, I will(In reply to comment #6)
> (From update of attachment 100245 [details])
> ok

Thanks, I'll commit this patch manually after results of the EWS bots are ready.
Comment 9 Yuta Kitamura 2011-07-11 00:51:38 PDT 
Committed r90726: <http://trac.webkit.org/changeset/90726>