Bug 64077 - DFG JIT does not implement get_by_id prototype caching
Summary: DFG JIT does not implement get_by_id prototype caching
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-07-07 02:31 PDT by Filip Pizlo
Modified: 2011-07-17 01:05 PDT (History)
2 users (show)

See Also:

the patch (8.59 KB, patch)
2011-07-07 02:50 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-07 02:31:16 PDT
The JSC JIT emits stubs to cache get_by_id prototype accesses.  The DFG JIT does not implement this optimization.
Comment 1 Filip Pizlo 2011-07-07 02:50:35 PDT
Created attachment 99963 [details]
the patch
Comment 2 Gavin Barraclough 2011-07-07 16:17:14 PDT
Comment on attachment 99963 [details]
the patch

I think there might be an alternative given the way we're currently code generating the self accesses.  We may be able to plant a couple of extra instructions inline in the JIT code to load to prototype & check its structure, immediately prior to the load.  But this is just a possible idea to explore - patch as is looks fine.
Comment 3 WebKit Review Bot 2011-07-07 16:48:52 PDT
Comment on attachment 99963 [details]
the patch

Clearing flags on attachment: 99963

Committed r90601: <http://trac.webkit.org/changeset/90601>
Comment 4 WebKit Review Bot 2011-07-07 16:48:56 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gavin Barraclough 2011-07-08 16:43:40 PDT
Reopening - these changes were rolled out in r90673 due to https://bugs.webkit.org/show_bug.cgi?id=64181
Comment 6 Gavin Barraclough 2011-07-17 01:05:27 PDT
Closing, I think these changes were landed as a part of another bug.  Filip, please reopen if I'm mistaken & this is still a live issue.