Bug 63970 – new-run-webkit-tests doesn't understand --qt or --gtk

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

new-run-webkit-tests doesn't understand --qt or --gtk
Requested by eseidel2 on #webkit.

[Eric Seidel (no email)]

I've committed a workaround in run-webkit-tests for now:
http://trac.webkit.org/changeset/90431

[Eric Seidel (no email)]

Moving this to the polish stage.  This has not stopped Qt or Gtk from moving to NRWT.

[Eric Seidel (no email)]

Created attachment 112760 [details]
Patch

[Eric Seidel (no email)]

Very easy. :)  Clearly I need to spend some time cleaning up our options parsing code.

[Ojan Vafai]

Comment on attachment 112760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112760&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:312
>          optparse.make_option("--full-results-html", action="store_true",
>              default=False,
> -            help="Show all failures in results.html, rather than only "
> -                 "regressions"),
> +            help="Show all failures in results.html, rather than only regressions"),

Not related to this patch, but I *think* this is a misnomer now. I think all this does is that it decides whether we open the results.html page in cases where all the failures are expected (e.g. they're all listed in test_expectations).

I guess what it should do is open the results.html page with the show expected failures checkbox checked.

[WebKit Review Bot]

Comment on attachment 112760 [details]
Patch

Clearing flags on attachment: 112760

Committed r98665: <http://trac.webkit.org/changeset/98665>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.