Bug 63970 - new-run-webkit-tests doesn't understand --qt or --gtk
Summary: new-run-webkit-tests doesn't understand --qt or --gtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 64491
  Show dependency treegraph
 
Reported: 2011-07-05 20:31 PDT by WebKit Review Bot
Modified: 2011-10-27 17:21 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.76 KB, patch)
2011-10-27 14:53 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-07-05 20:31:39 PDT
new-run-webkit-tests doesn't understand --qt or --gtk
Requested by eseidel2 on #webkit.
Comment 1 Eric Seidel (no email) 2011-07-05 20:36:33 PDT
I've committed a workaround in run-webkit-tests for now:
http://trac.webkit.org/changeset/90431
Comment 2 Eric Seidel (no email) 2011-10-24 10:35:39 PDT
Moving this to the polish stage.  This has not stopped Qt or Gtk from moving to NRWT.
Comment 3 Eric Seidel (no email) 2011-10-27 14:53:47 PDT
Created attachment 112760 [details]
Patch
Comment 4 Eric Seidel (no email) 2011-10-27 14:54:11 PDT
Very easy. :)  Clearly I need to spend some time cleaning up our options parsing code.
Comment 5 Ojan Vafai 2011-10-27 15:09:36 PDT
Comment on attachment 112760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112760&action=review

> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:312
>          optparse.make_option("--full-results-html", action="store_true",
>              default=False,
> -            help="Show all failures in results.html, rather than only "
> -                 "regressions"),
> +            help="Show all failures in results.html, rather than only regressions"),

Not related to this patch, but I *think* this is a misnomer now. I think all this does is that it decides whether we open the results.html page in cases where all the failures are expected (e.g. they're all listed in test_expectations).

I guess what it should do is open the results.html page with the show expected failures checkbox checked.
Comment 6 WebKit Review Bot 2011-10-27 17:21:25 PDT
Comment on attachment 112760 [details]
Patch

Clearing flags on attachment: 112760

Committed r98665: <http://trac.webkit.org/changeset/98665>
Comment 7 WebKit Review Bot 2011-10-27 17:21:30 PDT
All reviewed patches have been landed.  Closing bug.