Bug 63876 - SVGAnimateTransform accumulate=sum restarts on every repeat
Summary: SVGAnimateTransform accumulate=sum restarts on every repeat
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL: http://dev.w3.org/SVG/profiles/1.1F2/...
Keywords:
Depends on:
Blocks: 41761
  Show dependency treegraph
 
Reported: 2011-07-03 11:25 PDT by Dirk Schulze
Modified: 2011-07-04 06:37 PDT (History)
5 users (show)

See Also:


Attachments
Patch (8.37 KB, patch)
2011-07-03 12:02 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.65 MB, application/zip)
2011-07-03 12:20 PDT, WebKit Review Bot
no flags Details
Patch (8.30 KB, patch)
2011-07-03 12:56 PDT, Dirk Schulze
zimmermann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-07-03 11:25:59 PDT
SVGAnimateTransform accumulate=sum restarts on every repeat. Have a fix for it.
Comment 1 Dirk Schulze 2011-07-03 12:02:20 PDT
Created attachment 99576 [details]
Patch
Comment 2 WebKit Review Bot 2011-07-03 12:20:19 PDT
Comment on attachment 99576 [details]
Patch

Attachment 99576 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8977709

New failing tests:
svg/animations/svgtransform-animation-1.html
Comment 3 WebKit Review Bot 2011-07-03 12:20:25 PDT
Created attachment 99577 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Dirk Schulze 2011-07-03 12:56:42 PDT
Created attachment 99579 [details]
Patch
Comment 5 Nikolas Zimmermann 2011-07-03 13:01:43 PDT
Comment on attachment 99576 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99576&action=review

> Source/WebCore/ChangeLog:7
> +
> +        SVGAnimateTransform accumulate=sum restarts on every repeat
> +        https://bugs.webkit.org/show_bug.cgi?id=63876
> +
> +        Reviewed by NOBODY (OOPS!).
> +        

Order is wrong.

> Source/WebCore/ChangeLog:13
> +
> +        Test: svg/animations/svgtransform-animation-1.html

So what is fixed now? Again in one sentence pls.
Fix accumulate="sum" on <animateTransform>

> LayoutTests/svg/animations/svgtransform-animation-1-expected.txt:15
> +FAIL rect.transform.animVal.getItem(0).type should be 3. Was 13.
> +FAIL rect.transform.animVal.getItem(0).matrix.a should be close to 1. Was 0.
> +FAIL rect.transform.animVal.getItem(0).matrix.d should be close to 1. Was 0.

Fails?
Comment 6 Nikolas Zimmermann 2011-07-03 13:03:28 PDT
Comment on attachment 99579 [details]
Patch

Ah, r=me, sorry didn't see the new patch before.
Comment 7 Nikolas Zimmermann 2011-07-03 13:04:22 PDT
Comment on attachment 99579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99579&action=review

Ah, r=me, sorry didn't see the new patch before. But please fixup the ChangeLogs. (Or were there a recent change to the style? I remember discussions...)

> Source/WebCore/ChangeLog:6
> +        SVGAnimateTransform accumulate=sum restarts on every repeat
> +        https://bugs.webkit.org/show_bug.cgi?id=63876
> +
> +        Reviewed by NOBODY (OOPS!).

Order is wrong.
Comment 8 Adam Barth 2011-07-03 13:05:17 PDT
> Order is wrong.

Apparently this order change is intentional.  There was a thread on webkit-dev about it.
Comment 9 Dirk Schulze 2011-07-03 13:22:43 PDT
Committed r90345: <http://trac.webkit.org/changeset/90345>
Comment 10 Marcus Bulach 2011-07-04 06:37:11 PDT
Hello,

This new test is failing on some of the chromium bots.
Logs and more details at: 
https://bugs.webkit.org/show_bug.cgi?id=63902

I disabled it temporarily on the failing platforms (apparently it's ok on linux but fails on mac / win). Would you mind taking a quick look at it, please? Any help would be greatly appreciated!