RESOLVED FIXED 63795
ReportCrash destabilizes new-run-webkit-tests 
https://bugs.webkit.org/show_bug.cgi?id=63795
Summary ReportCrash destabilizes new-run-webkit-tests
Adam Barth
Reported 2011-07-01 02:09:54 PDT
ReportCrash destabilizes new-run-webkit-tests
Attachments
Patch (5.62 KB, patch)
2011-07-01 02:12 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-01 02:12:51 PDT
Created attachment 99445 [details] Patch
Adam Barth
Comment 2 2011-07-01 11:14:41 PDT
Comment on attachment 99445 [details] Patch Clearing flags on attachment: 99445 Committed r90246: <http://trac.webkit.org/changeset/90246>
Adam Barth
Comment 3 2011-07-01 11:14:44 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 4 2011-07-01 11:21:06 PDT
Comment on attachment 99445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99445&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:671 > + if self._port.executive().running_pids(self._port.is_crash_reporter): This call is expensive. How often do we run this?
Eric Seidel (no email)
Comment 5 2011-07-01 11:21:23 PDT
CCing ossy in case this slows down the Qt bots again.
Adam Barth
Comment 6 2011-07-01 11:30:47 PDT
> This call is expensive. How often do we run this? Once a second. If it turns out to be a problem, I have an idea how to optimize it.
Eric Seidel (no email)
Comment 7 2011-07-01 11:37:24 PDT
It's not entirely clear to me why ReportCrash would destablize the run, since DRT should theoretically be taking up 100% of the CPU before it crashes, so the fact that ReportCrash is taking up 100% of that core in DRT's stead should be OK. Do we run more DRTs than we have cores? (Actually I think we run 2x iirc?)
Adam Barth
Comment 8 2011-07-01 11:41:51 PDT
Maybe it's something specific to my system? ReportCrash make the UI in all my programs sluggish, maybe because causing the kernel to do a lot of work somehow? Anecdotally, this patch has been a big stability win on my machine. Crashes in some tests used to trigger other tests to timeout, and that doesn't happen anymore.
Dirk Pranke
Comment 9 2011-07-01 12:50:10 PDT
Comment on attachment 99445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99445&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:132 > + self._port.executive().wait_newest(self._port.is_crash_reporter) You might want to wait for the crash reporter in worker._run_test instead, since you can do in between tests (when the test timeout does not apply).
Adam Barth
Comment 10 2011-07-01 13:21:34 PDT
> You might want to wait for the crash reporter in worker._run_test instead, since you can do in between tests (when the test timeout does not apply). https://bugs.webkit.org/show_bug.cgi?id=63837
Note You need to log in before you can comment on or make changes to this bug.