Bug 63837 - We shouldn't wait for ReportCrash while the timeout is running
Summary: We shouldn't wait for ReportCrash while the timeout is running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 13:16 PDT by Adam Barth
Modified: 2011-07-01 14:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.62 KB, patch)
2011-07-01 13:17 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-01 13:16:18 PDT
We shouldn't wait for ReportCrash while the timeout is running
Comment 1 Adam Barth 2011-07-01 13:17:28 PDT
Created attachment 99513 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-01 13:19:59 PDT
Comment on attachment 99513 [details]
Patch

Makes sense.  How do we test this?
Comment 3 Dirk Pranke 2011-07-01 13:20:39 PDT
Comment on attachment 99513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99513&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py:133
> +        self._port.executive().wait_newest(self._port.is_crash_reporter)

Does it make sense to only do this if the previous test crashed? 

Or was it your intent to block *every* worker if a crash reporter is running? It will be interesting to see what kind of impact that has on test run time on the many-core machines like the big mac pros and xserves.
Comment 4 Adam Barth 2011-07-01 13:23:44 PDT
> Or was it your intent to block *every* worker if a crash reporter is running?

Yes.

> It will be interesting to see what kind of impact that has on test run time on the many-core machines like the big mac pros and xserves.

In my machine (a big mac pro), this appears to be necessary for test stability.  When tests crash (rare), it adds ~minutes of waiting.
Comment 5 WebKit Review Bot 2011-07-01 14:21:21 PDT
Comment on attachment 99513 [details]
Patch

Clearing flags on attachment: 99513

Committed r90277: <http://trac.webkit.org/changeset/90277>
Comment 6 WebKit Review Bot 2011-07-01 14:21:25 PDT
All reviewed patches have been landed.  Closing bug.