Bug 63672 - Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Position&)
Summary: Replace isNodeInTextFormControl(Node*) by enclosingTextFormControl(const Posi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 52099
  Show dependency treegraph
 
Reported: 2011-06-29 17:12 PDT by Ryosuke Niwa
Modified: 2011-06-30 02:14 PDT (History)
6 users (show)

See Also:


Attachments
cleanup (12.27 KB, patch)
2011-06-29 18:55 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-29 17:12:25 PDT
Right now, isNodeInTextFormControl takes Node* but this results in various editing code calling this function with deprecatedNode.  Also, there are many places where we'd like to obtain the enclosing text form control.

We can cleanup these code by introducing enclosingTextFormControl(const Position&) that replaces isNodeInTextFormControl(Node*).
Comment 1 Ryosuke Niwa 2011-06-29 18:55:49 PDT
Created attachment 99207 [details]
cleanup
Comment 2 Kent Tamura 2011-06-30 01:58:20 PDT
Comment on attachment 99207 [details]
cleanup

Looks good cleanup.
Comment 3 WebKit Review Bot 2011-06-30 02:14:30 PDT
Comment on attachment 99207 [details]
cleanup

Clearing flags on attachment: 99207

Committed r90098: <http://trac.webkit.org/changeset/90098>
Comment 4 WebKit Review Bot 2011-06-30 02:14:35 PDT
All reviewed patches have been landed.  Closing bug.