Bug 63549 - new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled
Summary: new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
: 63523 (view as bug list)
Depends on:
Blocks: 34984
  Show dependency tree / graph
 
Reported: 2011-06-28 11:28 PDT by Eric Seidel (no email)
Modified: 2011-06-29 17:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.08 KB, patch)
2011-06-28 11:31 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-06-28 11:28:55 PDT 
new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled
Comment 1 Eric Seidel (no email) 2011-06-28 11:31:19 PDT 
Created attachment 98950 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-28 11:38:44 PDT 
Just slowly burning down the list of failures on http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28NRWT%29
Comment 3 Tony Chang 2011-06-28 11:45:04 PDT 
Comment on attachment 98950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review

> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89
> +        expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"])

Nit: Should we sort these alphabetically?
Comment 4 Eric Seidel (no email) 2011-06-28 11:48:36 PDT 
Comment on attachment 98950 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review

Thanks for the review!

>> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89
>> +        expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"])
> 
> Nit: Should we sort these alphabetically?

I'm not sure it really matters given that they're a set.  :)
Comment 5 Tony Chang 2011-06-28 11:55:49 PDT 
(In reply to comment #4)
> (From update of attachment 98950 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review
> 
> Thanks for the review!
> 
> >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89
> >> +        expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"])
> > 
> > Nit: Should we sort these alphabetically?
> 
> I'm not sure it really matters given that they're a set.  :)

The sorting is to make it easier for humans to read, not the computer :)
Comment 6 WebKit Review Bot 2011-06-28 12:33:40 PDT 
Comment on attachment 98950 [details]
Patch

Clearing flags on attachment: 98950

Committed r89949: <http://trac.webkit.org/changeset/89949>
Comment 7 WebKit Review Bot 2011-06-28 12:33:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2011-06-29 17:18:04 PDT 
*** Bug 63523 has been marked as a duplicate of this bug. ***