Bug 63397 – SVGAnimatedType should support SVGNumberOptionalNumber animation

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

SVGAnimatedType should support SVGNumberOptionalNumber animation.

[Dirk Schulze]

Created attachment 98620 [details]
Patch

[WebKit Review Bot]

Attachment 98620 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1

Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:40:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:40:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:41:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:41:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.h:43:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:49:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:49:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:60:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:60:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:78:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:78:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Source/WebCore/svg/SVGAnimatedNumberOptionalNumber.cpp:78:  The parameter type should use PassOwnPtr instead of OwnPtr.  [readability/pass_ptr] [5]
Total errors found: 14 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nikolas Zimmermann]

Comment on attachment 98620 [details]
Patch

r=me!

[Dirk Schulze]

Committed r89766: <http://trac.webkit.org/changeset/89766>

[Adam Barth]

This patch added

using namespace std;

to a header file.  That seems pretty uncool.  /me will fixenate.

[Adam Barth]

Fixenated in http://trac.webkit.org/changeset/89786

[Dirk Schulze]

(In reply to comment #6)
> Fixenated in http://trac.webkit.org/changeset/89786

Oh, sorry. Thanks for fixing.

[Adam Barth]

For the record, this caused broke the clang build.  We don't have much clang coverage on webkit.org, so it's easy to break that build.  Adding more coverage is on my list of things I'd like to do, but it's not at the top yet.