Bug 63329 – [Symbian] Fix compile error in RVCT 2.2 build

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Stanislav Paltis]

Compile error when building QtWebkit 2.2 with RVCT 2.2 compile
"....\Source\WebCore\rendering\RenderInline.cpp", line 300: Error:  #410-D: protected function "WebCore::RenderBoxModelObject::setContinuation" is not accessible through a "WebCore::RenderBlock" pointer or object

      middleBlock->setContinuation(clone);

Fix in RenderBlock.h, similar to:
https://bugs.webkit.org/show_bug.cgi?id=47187
https://bugs.webkit.org/show_bug.cgi?id=51873
https://bugs.webkit.org/show_bug.cgi?id=62219

[Stanislav Paltis]

Created attachment 98507 [details]
replaced "using" for RVCT 2.2 compile

[Stanislav Paltis]

Created attachment 99101 [details]
replaced "using" for RVCT 2.2 compile, Changelog update.

[Darin Adler]

Comment on attachment 99101 [details]
replaced "using" for RVCT 2.2 compile, Changelog update.

In the other cases where we used an inline instead of using to make things easier on RVCT we added a comment. Otherwise, since we have no RVCT buildbot, it’s reasonable for someone to just change the inline back. Could you find one of those other cases and use a similar comment here?

[Stanislav Paltis]

Created attachment 99346 [details]
Added comment in the code based on David's suggestion.

[Daniel Bates]

Comment on attachment 99346 [details]
Added comment in the code based on David's suggestion.

View in context: https://bugs.webkit.org/attachment.cgi?id=99346&action=review

> Source/WebCore/rendering/RenderBlock.h:161
>      using RenderBoxModelObject::continuation;

Wouldn't we need something similar here since RenderBoxModelObject::continuation() is also a protected method and we want to expose its functionality in a public method?

> Source/WebCore/rendering/RenderBlock.h:162
> +    // Canât use "using" here due to a bug in the RVCT compiler.

The encoding for the apostrophe character is messed up.

[Eric Seidel (no email)]

Stanislav is not a committer.  Did you mean to r- this Dan?

[Daniel Bates]

Comment on attachment 99346 [details]
Added comment in the code based on David's suggestion.

I'm r-ing this patch since I asked a question and mentioned a minor nit with this patch in comment 5 and it hasn't been addressed in almost 6 months.

[Laszlo Gombos]

Closed as WONTFIX - see https://lists.webkit.org/pipermail/webkit-qt/2011-October/001979.html. RVCT 2.2 was only used by the Symbian port.