Bug 62219 - [Symbian] Float{32,64}Array and Int16Array fail to build.
Summary: [Symbian] Float{32,64}Array and Int16Array fail to build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-07 10:16 PDT by Andreas Kling
Modified: 2011-06-08 08:48 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (3.27 KB, patch)
2011-06-07 10:16 PDT, Andreas Kling
laszlo.gombos: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-06-07 10:16:23 PDT
SSIA
Comment 1 Andreas Kling 2011-06-07 10:16:59 PDT
Created attachment 96255 [details]
Proposed patch
Comment 2 Kenneth Rohde Christiansen 2011-06-07 10:18:25 PDT
Comment on attachment 96255 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96255&action=review

Working on Symbian now :-) ?

> Source/WebCore/html/canvas/Float32Array.h:41
> +    // Can’t use "using" here due to a bug in the RVCT compiler.

Wrong encoding it seems

> Source/WebCore/html/canvas/Float64Array.h:41
> +    // Can’t use "using" here due to a bug in the RVCT compiler.

Same here
Comment 3 Laszlo Gombos 2011-06-07 12:22:56 PDT
Comment on attachment 96255 [details]
Proposed patch

LGTM. 

It would be good to mention that this is only needed for RVCT 2.2 (and not 4.0) for future reference in the ChangeLog.


The encoding looks to be OK, unless one clicks on "Review patch". Perhaps an issue with "Review patch" ?
Comment 4 Andreas Kling 2011-06-08 03:52:54 PDT
Committed r88336: <http://trac.webkit.org/changeset/88336>
Comment 5 Ademar Reis 2011-06-08 08:48:27 PDT
Revision r88336 cherry-picked into qtwebkit-2.2 with commit d7ac689 <http://gitorious.org/webkit/qtwebkit/commit/d7ac689>