| Summary: | [Symbian] Float{32,64}Array and Int16Array fail to build. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | New Bugs | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ademar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2011-06-07 10:16:23 PDT
Created attachment 96255 [details]
Proposed patch
Comment on attachment 96255 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=96255&action=review Working on Symbian now :-) ? > Source/WebCore/html/canvas/Float32Array.h:41 > + // Canât use "using" here due to a bug in the RVCT compiler. Wrong encoding it seems > Source/WebCore/html/canvas/Float64Array.h:41 > + // Canât use "using" here due to a bug in the RVCT compiler. Same here Comment on attachment 96255 [details]
Proposed patch
LGTM.
It would be good to mention that this is only needed for RVCT 2.2 (and not 4.0) for future reference in the ChangeLog.
The encoding looks to be OK, unless one clicks on "Review patch". Perhaps an issue with "Review patch" ?
Committed r88336: <http://trac.webkit.org/changeset/88336> Revision r88336 cherry-picked into qtwebkit-2.2 with commit d7ac689 <http://gitorious.org/webkit/qtwebkit/commit/d7ac689> |