Bug 63178 – REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Jessie Berlin]

http/tests/inspector/extensions-resources-redirect.html has been failing on SnowLeopard Intel Release (Tests) since r89449.

http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89448%20(30637)/results.html passed
http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r89449%20(30638)/results.html failed

This is happening on Windows as well: 

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89462%20(14031)/http/tests/inspector/extensions-resources-redirect-pretty-diff.html

[Jessie Berlin]

Added expected failing results http://trac.webkit.org/changeset/89477

[Jessie Berlin]

<rdar://problem/9658001>

[Csaba Osztrogonác]

I skipped it on Qt: http://trac.webkit.org/changeset/89570

But I don't think if it is a good idea to check in expected fails and/or skipping a failing test because of a regression. Regressions shouldn't be in trunk.

[Vsevolod Vlasov]

this is a problem in test, not in the code, I have a patch ready and will upload it tomorrow.

[Vsevolod Vlasov]

Created attachment 98492 [details]
Patch

[Adam Roben (:aroben)]

I wonder if this fill fix bug 63325 and/or bug 57491?

[Vsevolod Vlasov]

(In reply to comment #6)
> I wonder if this fill fix bug 63325 and/or bug 57491?

I don't think so.
I was not aware of these bugs, and could have a deeper look on them, but they are most probably related to the test implementation details, that were present in it initially, while this patch only fixes the problem caused by recent changes in a way inspector receives resources content.

[Jessie Berlin]

Comment on attachment 98492 [details]
Patch

Unofficial r=me (I am not a reviewer yet)

[Pavel Feldman]

Comment on attachment 98492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98492&action=review

> LayoutTests/platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt:-1
> -Tests WebInspector extension API

Are you expecting this blank output on a Mac?

[Pavel Feldman]

Comment on attachment 98492 [details]
Patch

Ah! you removed the custom expectation!

[Andrey Kosyakov]

Manually committed r89931: http://trac.webkit.org/changeset/89931