Bug 63171 - Convert SVGPointList to SVGAnimatorFactory concept
Summary: Convert SVGPointList to SVGAnimatorFactory concept
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 41761
  Show dependency tree / graph
 
Reported: 2011-06-22 12:58 PDT by Dirk Schulze
Modified: 2011-06-22 23:32 PDT (History)
3 users (show)

See Also:

Attachments
Patch (32.74 KB, patch)
2011-06-22 13:15 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch (40.14 KB, patch)
2011-06-22 13:55 PDT, Dirk Schulze 		rwlbuis: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-06-22 12:58:07 PDT 
Convert SVGPointList to SVGAnimatorFactory concept.
Comment 1 Dirk Schulze 2011-06-22 13:15:31 PDT 
Created attachment 98227 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-22 13:24:16 PDT 
Comment on attachment 98227 [details]
Patch

Attachment 98227 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8924674
Comment 3 Early Warning System Bot 2011-06-22 13:33:28 PDT 
Comment on attachment 98227 [details]
Patch

Attachment 98227 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8921756
Comment 4 Dirk Schulze 2011-06-22 13:55:29 PDT 
Created attachment 98236 [details]
Patch
Comment 5 Rob Buis 2011-06-22 14:38:55 PDT 
Comment on attachment 98236 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98236&action=review

LGTM

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:999
> +		43B9336A13B261B1004584BF /* SVGAnimatedPointList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 43B9336813B261B1004584BF /* SVGAnimatedPointList.cpp */; };

You may want to sort this.

> Source/WebCore/svg/SVGAnimatedPointList.cpp:86
> +            animatedPointList = ((animationMode == FromToAnimation && percentage > 0.5f) || animationMode == ToAnimation || percentage == 1) 

0.5f -> 0.5
Comment 6 Dirk Schulze 2011-06-22 23:32:23 PDT 
Committed r89536: <http://trac.webkit.org/changeset/89536>