Bug 63003 - REGRESSION (r79060): Searching for a flight at united.com fails
Summary: REGRESSION (r79060): Searching for a flight at united.com fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adele Peterson
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-06-20 11:32 PDT by Adele Peterson
Modified: 2011-06-20 12:47 PDT (History)
2 users (show)

See Also:

Attachments
patch (4.33 KB, patch)
2011-06-20 11:40 PDT, Adele Peterson 		no flags Details | Formatted Diff | Diff
patch (4.55 KB, patch)
2011-06-20 11:54 PDT, Adele Peterson 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2011-06-20 12:44 PDT, Oliver Hunt 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adele Peterson 2011-06-20 11:32:18 PDT 
REGRESSION (r79060): Searching for a flight at united.com fails
Comment 1 Adele Peterson 2011-06-20 11:36:06 PDT 
Steps to reproduce:

1.  Go to ual.com
2.  Click on the 'Redeem Miles' tab
3.  Click on 'One-way'
4.  Click in the departure field which will pop up a calendar, choose a date (e.g. 8/20/2011 is what I was using)
5.  Enter departure and arrival cities (like SFO and EWR)
6.  Click Search
Comment 2 Adele Peterson 2011-06-20 11:40:49 PDT 
Created attachment 97829 [details]
patch
Comment 3 Adele Peterson 2011-06-20 11:53:59 PDT 
The original patch also broke Twitter, and we tried to refine the original change to fix that in this bug:

https://bugs.webkit.org/show_bug.cgi?id=55228
http://trac.webkit.org/changeset/80542

My patch reverts the original change, and we can figure out how to refix this without breaking Twitter and United later.
Comment 4 Adele Peterson 2011-06-20 11:54:25 PDT 
Created attachment 97831 [details]
patch
Comment 5 Oliver Hunt 2011-06-20 12:03:34 PDT 
Comment on attachment 97831 [details]
patch

Is there a testcase for the date that broke? rolling out this patch without adding a test for the breakage is going to make it hard to fix parsing properly without potentially reintroducing this bug again.
Comment 6 Oliver Hunt 2011-06-20 12:13:18 PDT 
Quick check implies that we need a test for 
new Date("Mon Jun 20 11:01:36 CDT 2011")
Comment 7 Oliver Hunt 2011-06-20 12:44:50 PDT 
Created attachment 97841 [details]
Patch
Comment 8 Oliver Hunt 2011-06-20 12:46:43 PDT 
Committed r89281: <http://trac.webkit.org/changeset/89281>
Comment 9 Darin Adler 2011-06-20 12:47:02 PDT 
<rdar://problem/9637155>