RESOLVED FIXED 62959
[EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h 
https://bugs.webkit.org/show_bug.cgi?id=62959
Summary [EFL] Add some PLATFORM(EFL) ifdefs to GraphicsContext3D.h
Hyowon Kim
Reported 2011-06-19 19:21:17 PDT
This patch adds some PLATFORM(EFL) ifdefs to GraphicsContext3D.cpp.
Attachments
Patch (2.17 KB, patch)
2011-06-19 19:53 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Patch (2.12 KB, patch)
2011-06-20 02:18 PDT, Hyowon Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hyowon Kim
Comment 1 2011-06-19 19:53:32 PDT
Created attachment 97733 [details] Patch
Gyuyoung Kim
Comment 2 2011-06-19 21:22:40 PDT
Comment on attachment 97733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review > Source/WebCore/ChangeLog:8 > + No new functionality, no new tests. If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description.
Hyowon Kim
Comment 3 2011-06-20 02:18:01 PDT
Created attachment 97767 [details] Patch
Hyowon Kim
Comment 4 2011-06-20 02:25:25 PDT
(In reply to comment #2) > (From update of attachment 97733 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97733&action=review > > > Source/WebCore/ChangeLog:8 > > + No new functionality, no new tests. > > If your patch doesn't have test cases, AFAIK, you don't need to add above line. If you want to add this line, please write it below summary description. Thanks Gyuyoung. I've deleted the line.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-06-20 07:05:32 PDT
The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there?
Hyowon Kim
Comment 6 2011-06-20 20:02:38 PDT
(In reply to comment #5) > The patch looks OK, but shouldn't it actually depend on bug 62709 as it depends on the functions implemented there? You're right~ I agree. I will modify the dependency. Thanks
Ryuan Choi
Comment 7 2011-06-27 00:30:33 PDT
Informal r+ on my side. Could anyone review this?
Gyuyoung Kim
Comment 8 2011-06-27 00:39:02 PDT
CC'ing Martin and Dirk. Martin and Dirk, Could you please review this patch?
WebKit Review Bot
Comment 9 2011-06-27 09:57:22 PDT
Comment on attachment 97767 [details] Patch Clearing flags on attachment: 97767 Committed r89827: <http://trac.webkit.org/changeset/89827>
WebKit Review Bot
Comment 10 2011-06-27 09:57:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.