Bug 62890 - Drop MutableTextTrack and make TextTrack always mutable
Summary: Drop MutableTextTrack and make TextTrack always mutable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks: 43668
  Show dependency tree / graph
 
Reported: 2011-06-17 11:05 PDT by Anna Cavender
Modified: 2011-10-24 07:41 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch (32.24 KB, text/plain)
2011-10-20 14:58 PDT, Eric Carlson 		no flags Details
Updated patch (34.99 KB, patch)
2011-10-21 09:06 PDT, Eric Carlson 		gustavo.noronha: commit-queue-
Details | Formatted Diff | Diff
Updated patch (36.52 KB, patch)
2011-10-21 15:03 PDT, Eric Carlson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Cavender 2011-06-17 11:05:24 PDT 
This change adds MutableTextTrack capabilities (addTextTrack() in HTMLMediaElement, and addCue() and removeCue() in MutableTextTrack, plus required functionality).
Comment 1 Anna Cavender 2011-10-19 21:09:18 PDT 
MutableTextTrack was recently removed from the whatwg spec:
http://html5.org/tools/web-apps-tracker?from=6709&to=6710
Comment 2 Eric Carlson 2011-10-20 14:58:22 PDT 
Created attachment 111853 [details]
Proposed patch

Pull MutableTextTrack functionality into TextTrack.
Comment 3 Gustavo Noronha (kov) 2011-10-20 19:18:37 PDT 
Comment on attachment 111853 [details]
Proposed patch

Attachment 111853 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10177708
Comment 4 Radar WebKit Bug Importer 2011-10-21 09:05:28 PDT 
<rdar://problem/10324494>
Comment 5 Eric Carlson 2011-10-21 09:06:02 PDT 
Created attachment 111973 [details]
Updated patch

Remove MutableTextTrack and its friends from a few more build files.
Comment 6 Collabora GTK+ EWS bot 2011-10-21 09:29:16 PDT 
Comment on attachment 111973 [details]
Updated patch

Attachment 111973 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10181909
Comment 7 Sam Weinig 2011-10-21 11:29:36 PDT 
Comment on attachment 111973 [details]
Updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111973&action=review

This change is testable, since there shouldn't be a window.MutableTextTrack property anymore.  Was there no test for that before?  Is it not exposed on DOMWindow.idl at all yet?

> Source/WebCore/html/HTMLMediaElement.cpp:1986
> +    RefPtr<TextTrack> track = TextTrack::create(this, kind, label, language);
> +    return track.release();

This RefPtr is not necessary.
Comment 8 Eric Carlson 2011-10-21 14:58:44 PDT 
(In reply to comment #7)
> (From update of attachment 111973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111973&action=review
> 
> This change is testable, since there shouldn't be a window.MutableTextTrack property anymore.  Was there no test for that before?  Is it not exposed on DOMWindow.idl at all yet?
> 
No, not all of the cue classes are in DOMWindow.idl yet. I will file a bug about this.

> > Source/WebCore/html/HTMLMediaElement.cpp:1986
> > +    RefPtr<TextTrack> track = TextTrack::create(this, kind, label, language);
> > +    return track.release();
> 
> This RefPtr is not necessary.
Indeed, thanks!
Comment 9 Eric Carlson 2011-10-21 15:03:35 PDT 
Created attachment 112028 [details]
Updated patch
Comment 10 Eric Carlson 2011-10-24 07:41:18 PDT 
http://trac.webkit.org/changeset/98238