Bug 62807 - SVGAnimation should use direct unit animation for SVGAngle
Summary: SVGAnimation should use direct unit animation for SVGAngle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks: 41761
  Show dependency treegraph
 
Reported: 2011-06-16 12:03 PDT by Dirk Schulze
Modified: 2011-06-22 02:20 PDT (History)
6 users (show)

See Also:


Attachments
Patch (56.62 KB, patch)
2011-06-16 13:17 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (56.82 KB, patch)
2011-06-16 14:08 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (63.00 KB, patch)
2011-06-17 13:24 PDT, Dirk Schulze
rwlbuis: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-06-16 12:03:27 PDT
SVGAnimation should use direct unit animation for SVGAngle as analogue to SVGLength animation.
Comment 1 Dirk Schulze 2011-06-16 13:17:38 PDT
Created attachment 97481 [details]
Patch
Comment 2 Rob Buis 2011-06-16 13:33:25 PDT
Comment on attachment 97481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97481&action=review

r- for now since it will fail to compile on a lot of platforms right now.

> Source/WebCore/ChangeLog:9
> +        This patch continues the convertion to the new concept of SVGAnimatorFactory with SVGAngle. We can animte the SVG primitive datatype SVGAngle

conversion && animate

> Source/WebCore/ChangeLog:22
> +        * WebCore.xcodeproj/project.pbxproj:

You are missing at least vcproj and .pro files!

> Source/WebCore/CMakeLists.txt:1652
> +        svg/SVGAnimatedAnlge.cpp

typo!
Comment 3 Dirk Schulze 2011-06-16 14:08:12 PDT
Created attachment 97492 [details]
Patch
Comment 4 Collabora GTK+ EWS bot 2011-06-16 14:29:30 PDT
Comment on attachment 97492 [details]
Patch

Attachment 97492 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8878300
Comment 5 Early Warning System Bot 2011-06-16 14:30:21 PDT
Comment on attachment 97492 [details]
Patch

Attachment 97492 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8877333
Comment 6 Rob Buis 2011-06-16 14:30:31 PDT
Comment on attachment 97492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97492&action=review

Looks good in general, the description needs to be fixed though and I posted a question.

> Source/WebCore/svg/SVGAnimateElement.cpp:555
> +        || m_animatedAttributeType == AnimatedLength)

Could be on one line.

> LayoutTests/svg/animations/script-tests/svgangle-animation-deg-to-grad.js:1
> +description("Test SVGLength animation from px to cm.");

Please fix all descriptions.

> LayoutTests/svg/animations/script-tests/svgangle-animation-rad-to-grad.js:22
> +marker.appendChild(polyline);

Is it possible to put the above setup work into the html? Would make the js files smaller.
Comment 7 Dirk Schulze 2011-06-16 14:38:13 PDT
Did not add the file SVGAnimatedAngle.cpp. Shouldn't upload patches that late. :-)
Comment 8 Dirk Schulze 2011-06-17 13:24:28 PDT
Created attachment 97646 [details]
Patch
Comment 9 Rob Buis 2011-06-17 13:30:54 PDT
Comment on attachment 97646 [details]
Patch

Looks good, but make sure to update the ChangeLog for WebCore.pro change.
Comment 10 WebKit Review Bot 2011-06-17 13:43:40 PDT
Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8877713
Comment 11 WebKit Review Bot 2011-06-17 15:40:48 PDT
Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8881707
Comment 12 WebKit Review Bot 2011-06-17 16:47:46 PDT
Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8879738
Comment 13 WebKit Review Bot 2011-06-17 17:13:52 PDT
Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8876756
Comment 14 Dirk Schulze 2011-06-17 22:31:46 PDT
Committed r89187: <http://trac.webkit.org/changeset/89187>