SVGAnimation should use direct unit animation for SVGAngle

[Dirk Schulze]

SVGAnimation should use direct unit animation for SVGAngle as analogue to SVGLength animation.

[Dirk Schulze]

Created attachment 97481 [details]
Patch

[Rob Buis]

Comment on attachment 97481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97481&action=review

r- for now since it will fail to compile on a lot of platforms right now.

> Source/WebCore/ChangeLog:9
> +        This patch continues the convertion to the new concept of SVGAnimatorFactory with SVGAngle. We can animte the SVG primitive datatype SVGAngle

conversion && animate

> Source/WebCore/ChangeLog:22
> +        * WebCore.xcodeproj/project.pbxproj:

You are missing at least vcproj and .pro files!

> Source/WebCore/CMakeLists.txt:1652
> +        svg/SVGAnimatedAnlge.cpp

typo!

[Dirk Schulze]

Created attachment 97492 [details]
Patch

[Collabora GTK+ EWS bot]

Comment on attachment 97492 [details]
Patch

Attachment 97492 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8878300

[Early Warning System Bot]

Comment on attachment 97492 [details]
Patch

Attachment 97492 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8877333

[Rob Buis]

Comment on attachment 97492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97492&action=review

Looks good in general, the description needs to be fixed though and I posted a question.

> Source/WebCore/svg/SVGAnimateElement.cpp:555
> +        || m_animatedAttributeType == AnimatedLength)

Could be on one line.

> LayoutTests/svg/animations/script-tests/svgangle-animation-deg-to-grad.js:1
> +description("Test SVGLength animation from px to cm.");

Please fix all descriptions.

> LayoutTests/svg/animations/script-tests/svgangle-animation-rad-to-grad.js:22
> +marker.appendChild(polyline);

Is it possible to put the above setup work into the html? Would make the js files smaller.

[Dirk Schulze]

Did not add the file SVGAnimatedAngle.cpp. Shouldn't upload patches that late. :-)

[Dirk Schulze]

Created attachment 97646 [details]
Patch

[Rob Buis]

Comment on attachment 97646 [details]
Patch

Looks good, but make sure to update the ChangeLog for WebCore.pro change.

[WebKit Review Bot]

Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8877713

[WebKit Review Bot]

Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8881707

[WebKit Review Bot]

Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8879738

[WebKit Review Bot]

Comment on attachment 97646 [details]
Patch

Attachment 97646 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8876756

[Dirk Schulze]

Committed r89187: <http://trac.webkit.org/changeset/89187>