Bug 62794 - [GTK] Remove support for GTK+2 in WebKit2
Summary: [GTK] Remove support for GTK+2 in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-06-16 05:55 PDT by Carlos Garcia Campos
Modified: 2011-06-26 23:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch (8.91 KB, patch)
2011-06-16 05:58 PDT, Carlos Garcia Campos
xan.lopez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-06-16 05:55:57 PDT
Make WebKit2 require GTK+ 3.x unconditionally.
Comment 1 Carlos Garcia Campos 2011-06-16 05:58:15 PDT
Created attachment 97440 [details]
Patch
Comment 2 Xan Lopez 2011-06-16 07:06:02 PDT
Comment on attachment 97440 [details]
Patch

r=me
Comment 3 Carlos Garcia Campos 2011-06-16 08:40:11 PDT
Committed r89028: <http://trac.webkit.org/changeset/89028>
Comment 4 Gyuyoung Kim 2011-06-24 00:14:51 PDT
(In reply to comment #0)
> Make WebKit2 require GTK+ 3.x unconditionally.

Hello Carlos and Xan,

I have an ignorant question. I wonder why WebKit2 GTK port requires GTK3 unconditionally.
Comment 5 Martin Robinson 2011-06-24 07:08:02 PDT
(In reply to comment #4)
> (In reply to comment #0)
> > Make WebKit2 require GTK+ 3.x unconditionally.
> 
> I have an ignorant question. I wonder why WebKit2 GTK port requires GTK3 unconditionally.

Our reasoning was that by the time that we are ready to release WebKit2 in a stable branch, all Linux distributions will be shipping GTK+ 3.x as the default GTK+ version. Is it important to you to maintain GTK+ 2.x support for WebKit2?
Comment 6 Gyuyoung Kim 2011-06-26 18:59:44 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #0)
> > > Make WebKit2 require GTK+ 3.x unconditionally.
> > 
> > I have an ignorant question. I wonder why WebKit2 GTK port requires GTK3 unconditionally.
> 
> Our reasoning was that by the time that we are ready to release WebKit2 in a stable branch, all Linux distributions will be shipping GTK+ 3.x as the default GTK+ version. Is it important to you to maintain GTK+ 2.x support for WebKit2?

Hello Martin,

Long time no see. :-) I heard that flash 10.x version only supports GTK2 ver. So, my coworkers who focus on WebKit GTK wanna support GTK2 on WebKit2's GTK port for now.
Comment 7 Carlos Garcia Campos 2011-06-26 23:22:45 PDT
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #0)
> > > > Make WebKit2 require GTK+ 3.x unconditionally.
> > > 
> > > I have an ignorant question. I wonder why WebKit2 GTK port requires GTK3 unconditionally.
> > 
> > Our reasoning was that by the time that we are ready to release WebKit2 in a stable branch, all Linux distributions will be shipping GTK+ 3.x as the default GTK+ version. Is it important to you to maintain GTK+ 2.x support for WebKit2?
> 
> Hello Martin,
> 
> Long time no see. :-) I heard that flash 10.x version only supports GTK2 ver. So, my coworkers who focus on WebKit GTK wanna support GTK2 on WebKit2's GTK port for now.

The plugin process will use GTK2 unconditionally because of this reason. See bug #60546.