Bug 62779 - [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
Summary: [Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 62789
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-15 22:47 PDT by Sailesh Agrawal
Modified: 2011-06-16 14:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (25.17 KB, patch)
2011-06-15 22:48 PDT, Sailesh Agrawal
no flags Details | Formatted Diff | Diff
Patch (25.14 KB, patch)
2011-06-16 11:42 PDT, Sailesh Agrawal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sailesh Agrawal 2011-06-15 22:47:09 PDT
[Chromium] Update forked ScrollAnimatorChromiumMac.mm/h
Comment 1 Sailesh Agrawal 2011-06-15 22:48:04 PDT
Created attachment 97404 [details]
Patch
Comment 2 James Robinson 2011-06-15 23:09:13 PDT
Comment on attachment 97404 [details]
Patch

OK.  What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently?
Comment 3 Sailesh Agrawal 2011-06-15 23:12:43 PDT
(In reply to comment #2)
> (From update of attachment 97404 [details])
> OK.  What does the delta look like between ScrollAnimatorChromiumMac vs ScrollAnimatorMac currently?

Do you mean after this patch? It's not much:
  - change compile time #if USE(WK_SCROLLBAR_PAINTER) to runtime if (isScrollbarOverlayAPIAvailable())
  - early out in ScrollAnimatorChromiumMac::scroll if smooth scrolling is disabled
  - rename ScrollbarThemeMac to ScrollbarThemeChromiumMac
Comment 5 WebKit Review Bot 2011-06-16 00:12:06 PDT
Comment on attachment 97404 [details]
Patch

Clearing flags on attachment: 97404

Committed r89011: <http://trac.webkit.org/changeset/89011>
Comment 6 WebKit Review Bot 2011-06-16 00:12:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Sailesh Agrawal 2011-06-16 11:41:14 PDT
Re-opening since the original change got backed out.
Comment 8 Sailesh Agrawal 2011-06-16 11:42:30 PDT
Created attachment 97473 [details]
Patch
Comment 9 Sailesh Agrawal 2011-06-16 11:45:03 PDT
Merged latest changes from this revision:
https://trac.webkit.org/changeset/88982

Please take another look.
Comment 10 Mihai Parparita 2011-06-16 13:28:09 PDT
Comment on attachment 97473 [details]
Patch

Rubber-stamping since James is out.
Comment 11 WebKit Review Bot 2011-06-16 14:21:04 PDT
Comment on attachment 97473 [details]
Patch

Clearing flags on attachment: 97473

Committed r89066: <http://trac.webkit.org/changeset/89066>
Comment 12 WebKit Review Bot 2011-06-16 14:21:09 PDT
All reviewed patches have been landed.  Closing bug.