Bug 62711 - [EFL][WK2] Add missing functions of EFL port's PageClientImpl
Summary: [EFL][WK2] Add missing functions of EFL port's PageClientImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2011-06-15 03:16 PDT by Eunmi Lee
Modified: 2011-06-18 20:43 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.21 KB, patch)
2011-06-15 03:19 PDT, Eunmi Lee
no flags Details | Formatted Diff | Diff
Patch (3.21 KB, patch)
2011-06-15 19:49 PDT, Eunmi Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2011-06-15 03:16:12 PDT
I've added missing functions of EFL port's PageClientImpl.cpp.
There are 3 functions which is added in the latest PageClient.h.
+IntPoint PageClientImpl::screenToWindow(const IntPoint&)
+void PageClientImpl::enterAcceleratedCompositingMode(const LayerTreeContext&)
+void PageClientImpl::exitAcceleratedCompositingMode()
Comment 1 Eunmi Lee 2011-06-15 03:19:35 PDT
Created attachment 97266 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-06-15 03:22:46 PDT
Comment on attachment 97266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review

> Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170
> +IntPoint PageClientImpl::screenToWindow(const IntPoint&)
> +{
> +    notImplemented();
> +    return IntPoint();
> +}

Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0
Comment 3 Eunmi Lee 2011-06-15 19:49:24 PDT
Created attachment 97391 [details]
Patch
Comment 4 Eunmi Lee 2011-06-15 19:50:16 PDT
(In reply to comment #2)
> (From update of attachment 97266 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=97266&action=review
> 
> > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:170
> > +IntPoint PageClientImpl::screenToWindow(const IntPoint&)
> > +{
> > +    notImplemented();
> > +    return IntPoint();
> > +}
> 
> Maybe returning the given point makes more sense. This is a conversion method and converting it to the same will surely work better than converting everything to 0, 0

OK, I've changed to return the given point :)
Comment 5 Gyuyoung Kim 2011-06-15 21:46:49 PDT
LGTM.
Comment 6 Leandro Pereira 2011-06-16 06:54:40 PDT
(In reply to comment #4)
> 
> OK, I've changed to return the given point :)
>

Looks like you've sent the old patch again :)
Comment 7 Eunmi Lee 2011-06-16 17:40:11 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > 
> > OK, I've changed to return the given point :)
> >
> 
> Looks like you've sent the old patch again :)

Oh, I changed as follows :)
-169 return IntPoint()
+169 return point;
Comment 8 Leandro Pereira 2011-06-17 08:17:23 PDT
(In reply to comment #7)
> > 
> > Looks like you've sent the old patch again :)
> 
> Oh, I changed as follows :)
> -169 return IntPoint()
> +169 return point;

Oops, missed that :)
Comment 9 WebKit Review Bot 2011-06-18 20:43:00 PDT
Comment on attachment 97391 [details]
Patch

Clearing flags on attachment: 97391

Committed r89210: <http://trac.webkit.org/changeset/89210>
Comment 10 WebKit Review Bot 2011-06-18 20:43:06 PDT
All reviewed patches have been landed.  Closing bug.