Bug 62523 - [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
Summary: [EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 61838
  Show dependency treegraph
 
Reported: 2011-06-12 19:55 PDT by Eunmi Lee
Modified: 2011-06-13 14:52 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.38 KB, patch)
2011-06-12 19:58 PDT, Eunmi Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eunmi Lee 2011-06-12 19:55:29 PDT
This class's functions are not implemented yet, but it is needed to prevent build error.
Comment 1 Eunmi Lee 2011-06-12 19:58:20 PDT
Created attachment 96910 [details]
Patch
Comment 2 Gyuyoung Kim 2011-06-12 22:32:08 PDT
LGTM.
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-06-13 06:14:32 PDT
Looks OK after correcting the following nitpicks.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52
> +    return "";

I'd rather return a String() directly here.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:58
> +    return "";

Ditto.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:64
> +    return "";

Ditto.
Comment 4 Eric Seidel (no email) 2011-06-13 14:43:51 PDT
Comment on attachment 96910 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2011-06-13 14:51:55 PDT
Comment on attachment 96910 [details]
Patch

Clearing flags on attachment: 96910

Committed r88701: <http://trac.webkit.org/changeset/88701>
Comment 6 WebKit Review Bot 2011-06-13 14:52:00 PDT
All reviewed patches have been landed.  Closing bug.