Bug 62407 - LayoutTests/fast/css/link-disabled-attr.html fails some cases
Summary: LayoutTests/fast/css/link-disabled-attr.html fails some cases
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 65140
  Show dependency treegraph
 
Reported: 2011-06-09 15:13 PDT by Julien Chaffraix
Modified: 2012-02-25 13:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (9.41 KB, patch)
2011-08-04 07:56 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Chaffraix 2011-06-09 15:13:09 PDT
As part of bug 61400, some existing differences between us and FF + the spec when loading style sheets were exposed. Those are the 2 failures in link-disabled-attr.html.
Comment 1 David Kilzer (:ddkilzer) 2011-07-25 15:44:06 PDT
Likely related to Bug 65140 (which affects a real-world site).
Comment 2 Julien Chaffraix 2011-08-02 14:42:51 PDT
It looks like our binding does not use the same case as the spec and FireFox for one binding:

Document.idl:

// WebKit extensions

readonly attribute [ConvertNullStringTo=Null] DOMString preferredStylesheetSet;
         attribute [ConvertNullStringTo=Null, ConvertNullToNullString] DOMString selectedStylesheetSet;

The spec and Mozilla both use preferredStyleSheetSet and selectedStyleSheetSet. That could be why we are failing this test as we are matching the spec in our test.
Comment 3 Kentaro Hara 2011-08-04 07:56:49 PDT
Created attachment 102915 [details]
Patch
Comment 4 Kentaro Hara 2011-08-04 08:03:06 PDT
FYI: I found that document.selectedStyle"s"heetSet should be document.selectedStyleSheetSet. (spec: http://dev.w3.org/csswg/cssom/#dom-document-selectedStyleSheetSet) I would like to fix it after this patch is landed. (I guess that we should support both.)
Comment 5 Alexey Proskuryakov 2011-08-08 15:52:50 PDT
The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression.
Comment 6 Alexey Proskuryakov 2011-08-08 16:10:21 PDT
In fact, this patch doesn't seem to apply to ToT now.
Comment 7 Alexey Proskuryakov 2011-08-08 16:15:17 PDT
> In fact, this patch doesn't seem to apply to ToT now.

Strike that, my mistake.
Comment 8 Kentaro Hara 2011-08-08 16:57:14 PDT
(In reply to comment #5)
> The patch may conflict with bug 65140. I suggest getting that finished first, as it's an actual regression.

Thank you, I would like to rebase this patch and upload it, after the bug 65140 is landed.
Comment 9 John A. Bilicki III 2011-11-10 17:00:45 PST
I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post.
Comment 10 David Kilzer (:ddkilzer) 2011-11-11 02:44:35 PST
(In reply to comment #9)
> I came across it after creating a JavaScript theme switcher, WebKit browsers don't like it when I update the title attribute's value. I haven't been able to determine a fix for the problem save hard-wiring DOM detection to detect WebKit browsers and not update the theme titles. I haven't seen anyone else mention the title attribute so that is the main reason for me making this post.

Please open a new bug about this issue.
Comment 11 Julien Chaffraix 2012-02-25 13:30:30 PST
Comment on attachment 102915 [details]
Patch

Bug 65140 has landed some time ago. Clearing the review flag as the patch needs a rebaseline (mentioned in the bug and we ended up reverting most of the stylesheet loading so I don't know if the patch is still needed).