RESOLVED FIXED 61400
REGRESSION(84329): Stylesheets on some pages do not load
https://bugs.webkit.org/show_bug.cgi?id=61400
Summary REGRESSION(84329): Stylesheets on some pages do not load
Nico Weber
Reported 2011-05-24 15:17:25 PDT
Repro: 1. Go to http://www.tbray.org/ongoing/When/201x/2011/05/23/Intimations The page should render like it does in other browsers. Instead, it shows up without stylesheets. I bisected, and this is caused by r84329 (This is also http://crbug.com/83786)
Attachments
Proposed fix: Use a unified way of keeping the disabled information (14.26 KB, patch)
2011-06-01 16:45 PDT, Julien Chaffraix
no flags
Nico Weber
Comment 1 2011-05-24 15:21:31 PDT
Alexey Proskuryakov
Comment 2 2011-05-24 16:04:09 PDT
function setActiveStyleSheet(title) { var i, a, main; for (i=0; (a = document.getElementsByTagName("link")[i]); i++) { if (a.getAttribute("rel") && a.getAttribute("rel").indexOf("style") != -1 && a.getAttribute("title")) { a.disabled = true; if(a.getAttribute("title") == title) a.disabled = false; } } }
Nico Weber
Comment 3 2011-05-25 13:03:18 PDT
ap: Do you mean this bug should be closed WontFix?
Julien Chaffraix
Comment 4 2011-05-25 13:19:12 PDT
> ap: Do you mean this bug should be closed WontFix? FYI, the page works fine on other browsers. Also if you click on the 'Sans Sherif' link, this calls the function ap mentioned but the style is applied correctly. It is only the 'Sherif' style sheet (the default one) that is not applied properly. I think this should be investigated before closing.
Alexey Proskuryakov
Comment 5 2011-05-25 13:59:58 PDT
> ap: Do you mean this bug should be closed WontFix? No, definitely not. This snippet looks correct.
James Robinson
Comment 6 2011-05-25 16:44:26 PDT
Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web?
Julien Chaffraix
Comment 7 2011-05-25 19:17:43 PDT
(In reply to comment #6) > Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web? I am still investigating the issue but I lean towards an incorrect implementation in this case.
Julien Chaffraix
Comment 8 2011-06-01 16:45:23 PDT
Created attachment 95686 [details] Proposed fix: Use a unified way of keeping the disabled information
Antti Koivisto
Comment 9 2011-06-09 13:11:36 PDT
Comment on attachment 95686 [details] Proposed fix: Use a unified way of keeping the disabled information r=me
WebKit Review Bot
Comment 10 2011-06-09 13:33:31 PDT
Comment on attachment 95686 [details] Proposed fix: Use a unified way of keeping the disabled information Clearing flags on attachment: 95686 Committed r88479: <http://trac.webkit.org/changeset/88479>
WebKit Review Bot
Comment 11 2011-06-09 13:33:35 PDT
All reviewed patches have been landed. Closing bug.
Julien Chaffraix
Comment 12 2011-06-09 15:14:17 PDT
Filed bug 62407 to track the 2 failures in the new test case.
David Kilzer (:ddkilzer)
Comment 13 2011-07-26 09:18:12 PDT
Note You need to log in before you can comment on or make changes to this bug.