Bug 61400 - REGRESSION(84329): Stylesheets on some pages do not load
: REGRESSION(84329): Stylesheets on some pages do not load
Status: RESOLVED FIXED
: WebKit
CSS
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
: http://www.tbray.org/ongoing/When/201...
: InRadar
:
: 65140
  Show dependency treegraph
 
Reported: 2011-05-24 15:17 PST by
Modified: 2011-07-26 09:18 PST (History)


Attachments
Proposed fix: Use a unified way of keeping the disabled information (14.26 KB, patch)
2011-06-01 16:45 PST, Julien Chaffraix
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-05-24 15:17:25 PST
Repro:
1. Go to http://www.tbray.org/ongoing/When/201x/2011/05/23/Intimations

The page should render like it does in other browsers. Instead, it shows up without stylesheets.

I bisected, and this is caused by r84329

(This is also http://crbug.com/83786)
------- Comment #1 From 2011-05-24 15:21:31 PST -------
Clicky: http://trac.webkit.org/changeset/84329
------- Comment #2 From 2011-05-24 16:04:09 PST -------
function setActiveStyleSheet(title) {
    var i, a, main;
    for (i=0; (a = document.getElementsByTagName("link")[i]); i++) {
    if (a.getAttribute("rel") &&
            a.getAttribute("rel").indexOf("style") != -1 &&
            a.getAttribute("title")) {
        a.disabled = true;
        if(a.getAttribute("title") == title) a.disabled = false;
    }
    }
}
------- Comment #3 From 2011-05-25 13:03:18 PST -------
ap: Do you mean this bug should be closed WontFix?
------- Comment #4 From 2011-05-25 13:19:12 PST -------
> ap: Do you mean this bug should be closed WontFix?

FYI, the page works fine on other browsers.

Also if you click on the 'Sans Sherif' link, this calls the function ap mentioned but the style is applied correctly. It is only the 'Sherif' style sheet (the default one) that is not applied properly. I think this should be investigated before closing.
------- Comment #5 From 2011-05-25 13:59:58 PST -------
> ap: Do you mean this bug should be closed WontFix?

No, definitely not. This snippet looks correct.
------- Comment #6 From 2011-05-25 16:44:26 PST -------
Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web?
------- Comment #7 From 2011-05-25 19:17:43 PST -------
(In reply to comment #6)
> Does that mean that http://trac.webkit.org/changeset/84329 incorrectly implemented what HTML5 says to do, or that the behavior that HTML5 specifies is inconsistent with what other browsers do and incompatible with the web?

I am still investigating the issue but I lean towards an incorrect implementation in this case.
------- Comment #8 From 2011-06-01 16:45:23 PST -------
Created an attachment (id=95686) [details]
Proposed fix: Use a unified way of keeping the disabled information
------- Comment #9 From 2011-06-09 13:11:36 PST -------
(From update of attachment 95686 [details])
r=me
------- Comment #10 From 2011-06-09 13:33:31 PST -------
(From update of attachment 95686 [details])
Clearing flags on attachment: 95686

Committed r88479: <http://trac.webkit.org/changeset/88479>
------- Comment #11 From 2011-06-09 13:33:35 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #12 From 2011-06-09 15:14:17 PST -------
Filed bug 62407 to track the 2 failures in the new test case.
------- Comment #13 From 2011-07-26 09:18:12 PST -------
<rdar://problem/9567255>