Bug 62379 - WebKit2: Generate correct header conditionals in message receivers.
Summary: WebKit2: Generate correct header conditionals in message receivers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks: 62290
  Show dependency tree / graph
 
Reported: 2011-06-09 08:23 PDT by Andreas Kling
Modified: 2011-06-09 11:14 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (4.50 KB, patch)
2011-06-09 09:16 PDT, Andreas Kling 		kling: review-
Details | Formatted Diff | Diff
Proposed patch v2 (14.80 KB, patch)
2011-06-09 10:50 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-06-09 08:23:58 PDT 
Given a *.messages.in file like this:

Bar(WebCore::IntRect rect)
#if ENABLE(ESOTERIC_FEATURE)
Foo(WebCore::IntRect rect)
#endif

messages.py would include the WebCore argument coders only #if ENABLE(ESOTERIC_FEATURE). This breaks the build on platforms without that defined.

It also breaks for this case:

#if ENABLE(FOO)
Foo(WebCore::IntRect rect)
#endif
#if ENABLE(BAR)
Bar(WebCore::IntRect rect)
#endif

Where we would get the include only #if ENABLE(FOO). This should be #if ENABLE(FOO) || ENABLE(BAR) instead.
Comment 1 Andreas Kling 2011-06-09 09:16:52 PDT 
Created attachment 96595 [details]
Proposed patch
Comment 2 Andreas Kling 2011-06-09 09:27:35 PDT 
Comment on attachment 96595 [details]
Proposed patch

Self r- due to missing unit test. Didn't notice we have those for messages.py. :)
Comment 3 Andreas Kling 2011-06-09 10:50:43 PDT 
Created attachment 96604 [details]
Proposed patch v2
Comment 4 Andreas Kling 2011-06-09 11:14:28 PDT 
Comment on attachment 96604 [details]
Proposed patch v2

Clearing flags on attachment: 96604

Committed r88462: <http://trac.webkit.org/changeset/88462>
Comment 5 Andreas Kling 2011-06-09 11:14:36 PDT 
All reviewed patches have been landed.  Closing bug.