Bug 62290 – [Qt][WK2] Remove usage of deprecated CoreIPC functions.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andreas Kling]

TiledDrawingArea should move away from CoreIPC::deprecatedSend() and CoreIPC::deprecatedWaitFor().

[Andreas Kling]

Created attachment 96436 [details]
Proposed patch

Kill all use of CoreIPC::deprecated*() in TiledDrawingArea, and put the legacy DrawingArea{,Proxy} messages to rest.

[WebKit Review Bot]

Attachment 96436 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:118:  The parameter name "rect" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit2/UIProcess/TiledDrawingAreaProxy.h:119:  The parameter name "updateInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Comment on attachment 96436 [details]
Proposed patch

Looks great! You should make sure that it builds on Windows before landing though. Thanks for working on this!

[Eric Seidel (no email)]

Comment on attachment 96436 [details]
Proposed patch

Attachment 96436 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8825016

[Andreas Kling]

Comment on attachment 96436 [details]
Proposed patch

Clearing flags on attachment: 96436

Committed r88463: <http://trac.webkit.org/changeset/88463>

[Andreas Kling]

All reviewed patches have been landed.  Closing bug.