Bug 62299 – IndexedDB test: key sort order across types

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-construct states "For purposes of comparison, all Arrays are greater than all DOMString, Date and float values; all DOMString values are greater than all Date and float values; and all Date values are greater than all float values." Further, http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#dfn-object-store states "Each record consists of a key and a value. The list is sorted according to key in ascending order."

This test adds a number of keys not in sorted order, then opens and iterates a cursor to check that the keys appear in sorted order according ot the sort rules laid out in the spec.

WebKit passes this test.

[Mark Pilgrim (Google)]

Created attachment 96441 [details]
Patch

[David Grogan]

LGTM

This reminded me that we don't handle Date yet.

[David Grogan]

(In reply to comment #2)
> LGTM
> 
> This reminded me that we don't handle Date yet.

I guess bug 62300 proves this statement incorrect.

Why does this test not include comparing dates to these other types?  Just how the mozilla tests were?

[Mark Pilgrim (Google)]

Actually we're done with the Mozilla tests; these are original tests I made up last week (and am just getting around to uploading now).

I could add some dates, but I'd have to change how we're comparing values since new Date(0) != new Date(0) in JavaScript.

[David Grogan]

(In reply to comment #4)
> Actually we're done with the Mozilla tests; these are original tests I made up last week (and am just getting around to uploading now).

Hey, congratulations.  (Now I see that your usual link to the mozilla test isn't present here.)

> 
> I could add some dates, but I'd have to change how we're comparing values since new Date(0) != new Date(0) in JavaScript.

Following up in bug 62300.

[WebKit Review Bot]

Comment on attachment 96441 [details]
Patch

Clearing flags on attachment: 96441

Committed r88397: <http://trac.webkit.org/changeset/88397>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Hans Wennborg]

(In reply to comment #2)
> This reminded me that we don't handle Date yet.

I thought we did support dates. Am I missing something?

[David Grogan]

(In reply to comment #8)
> (In reply to comment #2)
> > This reminded me that we don't handle Date yet.
> 
> I thought we did support dates. Am I missing something?

We do, you're not missing anything.

I had a vague recollection of seeing a TODO somewhere that talked about *something* not supporting dates.  Now I'm trying to remember what that was about.

[Mark Pilgrim (Google)]

LayoutTests/storage/indexedb/tutorial.html mentions that WebKit does not support dates or arrays.


    // Keys can be integers, strings, or null. (The spec also defines dates and there's talk of
    // handling arrays, but these are not implemented yet in Chromium/WebKit.) 

I'd be happy to open another bug about updating the tutorial with current information, if you like.

[David Grogan]

(In reply to comment #10)
> LayoutTests/storage/indexedb/tutorial.html mentions that WebKit does not support dates or arrays.
> 
> 
>     // Keys can be integers, strings, or null. (The spec also defines dates and there's talk of
>     // handling arrays, but these are not implemented yet in Chromium/WebKit.) 
> 
> I'd be happy to open another bug about updating the tutorial with current information, if you like.

Sure!