Bug 62300 – IndexedDB test: key sort order for Date objects

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#key-construct states "Values of type Date are compared to other Date values chronologically." This test creates an objectstore and fills it with Date keys in non-chronological order, then opens and iterates a cursor to verify that the keys appear in chronological order.

WebKit passes this test.

[Mark Pilgrim (Google)]

Created attachment 96443 [details]
Patch

[David Grogan]

Comment on attachment 96443 [details]
Patch

LGTM

[David Grogan]

Comment on attachment 96443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96443&action=review

LGTM

> LayoutTests/storage/indexeddb/key-sort-order-date.html:89
> +            shouldBe("cursor.key.toString()", "sortedKeys[keyIndex]");

So the problem with dates is that shouldBe will try to compare Date objects using == ?  If so you might be able to use shouldEvaluateTo:
shouldEvaluateTo("cursor.key", sortedKeys[keyIndex])

if sortedKeys[keyIndex] holds a date.toString(), the == might call the Date object's toString method before comparing.

It's no big deal, the test is fine as is.  Only do this if you want to play around with javascript.

[Tony Chang]

Comment on attachment 96443 [details]
Patch

Mark, if you want to land this patch as-is, please set cq?.  Otherwise, just upload a new patch.

[WebKit Review Bot]

Comment on attachment 96443 [details]
Patch

Clearing flags on attachment: 96443

Committed r88395: <http://trac.webkit.org/changeset/88395>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.