Bug 62129 – Assertion failure in SQLiteDatabase::turnOnIncrementalAutoVacuum()

• Status: RESOLVED
• Resolution: WONTFIX
• Component: WebCore Misc.

[Clifford Hung]

SQLiteDatabase::turnOnIncrementalAutoVacuum() runs the VACUUM command on a database and this will result in an assertion failure in SQLite's btree.c (found while using SQLite version 3.7.2):

assert( !pBt->pPage1 && !pBt->pCursor ); in sqlite3BtreeSetPageSize(...)

This can be fixed by finalizing the statement that reads the auto_vacuum mode before running the VACUUM command as follows:

diff --git a/WebCore/platform/sql/SQLiteDatabase.cpp b/WebCore/platform/sql/SQLiteDatabase.cpp
index e7cef38..9d1bb34 100644
--- a/WebCore/platform/sql/SQLiteDatabase.cpp
+++ b/WebCore/platform/sql/SQLiteDatabase.cpp
@@ -444,6 +444,7 @@ bool SQLiteDatabase::turnOnIncrementalAutoVacuum()
     SQLiteStatement statement(*this, "PRAGMA auto_vacuum");
     int autoVacuumMode = statement.getColumnInt(0);
     int error = lastError();
+    statement.finalize();

     // Check if we got an error while trying to get the value of the auto_vacuum flag.
     // If we got a SQLITE_BUSY error, then there's probably another transaction in

[Ahmad Saleem]

WebKit SQLiteStatement implementation does not have "finalize" method, while possible potential error will be tracked via bug 249598.