RESOLVED FIXED 249598
Finalize to fix VACUUM error 
https://bugs.webkit.org/show_bug.cgi?id=249598
Summary Finalize to fix VACUUM error
Ahmad Saleem
Reported 2022-12-19 11:30:55 PST
Hi Team, While going through Blink's commit, I came across another potential merge: Blink Commit - https://chromium.googlesource.com/chromium/blink/+/5c41773bd57e33b38ef6aa2d049343abe5c18596 ^ No Test case unfortunately. WebKit source - https://searchfox.org/wubkat/source/Source/WebCore/platform/sql/SQLiteDatabase.cpp#670 This is still present in Chromium / Blink source: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/webdatabase/sqlite/sqlite_database.cc;l=401 Just wanted to raise this bug. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-12-23 17:51:25 PST
As per Bug 62129, this will fix assertion failure. Should we dupe this to earlier bug or we just close other one with this? Can I land this without testcase? I am happy to do PR.
Radar WebKit Bug Importer
Comment 2 2022-12-26 11:31:16 PST
<rdar://problem/103712693>
Ben Nham
Comment 3 2023-01-06 16:47:43 PST
Thanks for the bug report. We don't have a finalize method on SQLiteStatement. Instead we just count on the destructor to do that. Something like this should work (didn't test): https://gist.github.com/bnham/13547c6ea97f634254963958f778db28 Make a PR and I can review it. If it's simple enough I can accept it without a test case.
Ahmad Saleem
Comment 4 2023-01-06 17:50:59 PST
Fingers Crossed - https://github.com/WebKit/WebKit/pull/8341
EWS
Comment 5 2023-01-09 10:33:30 PST
Committed 258673@main (8217dce03e25): <https://commits.webkit.org/258673@main> Reviewed commits have been landed. Closing PR #8341 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.