Bug 61983 - [Meta] Elements with shadow DOM should produce viable clones
Summary: [Meta] Elements with shadow DOM should produce viable clones
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61909 61984 61985 61986 61987 61988 61997 62001
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-02 19:49 PDT by Dominic Cooney
Modified: 2011-06-08 19:23 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Cooney 2011-06-02 19:49:12 PDT
Cloning an element with shadow DOM can produce broken clones when elements in the shadow are implemented with derived C++ types. That is because these elements are cloned based on their tag names, not their actual C++ types. This is a tracking bug for fixing elements that fall into this trap.
Comment 1 Dominic Cooney 2011-06-08 19:23:04 PDT
We need to go through the dependent bugs, including closed ones, and:

1. Where there's a landed patch that overrides cloneElementWithoutAttributesAndChildren, determine if that is needed since the rollout in r88137. If not, we should remove the override. Don't revert the whole patch, though, since they contain useful tests.

Sometimes the landed regression tests are just for crash/element doesn't appear type regressions. They don't verify the functionality of cloned elements. We need to add verify that cloned elements are functional too.

2. Where there's no landed patch on a bug we should write a regression test that covers cloning and the functionality of cloned elements. These may expose functionality bugs, which we should file and fix. Close the bug when the test is landed and happy on the bots.