Bug 61686 - prevent HTMLLinkElement from watching multiple CachedResources
Summary: prevent HTMLLinkElement from watching multiple CachedResources
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 61720
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-28 07:38 PDT by Gavin Peters
Modified: 2011-05-30 10:05 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.42 KB, patch)
2011-05-28 07:45 PDT, Gavin Peters
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2011-05-28 07:38:33 PDT
prevent HTMLLinkElement from watching multiple CachedResources
Comment 1 Gavin Peters 2011-05-28 07:45:18 PDT
Created attachment 95260 [details]
Patch
Comment 2 Gavin Peters 2011-05-28 07:49:01 PDT
Comment on attachment 95260 [details]
Patch

This is a nasty bug that causes a lot of crashes in chromium; thanks to Ziga Mahkovec <ziga@google.com> for making a really good reproduction (I was chasing this bug, without success, for a while before he gave me that), and to Chris Bentzel <cbentzel@chromium.org> for making a first draft at a fix!
Comment 3 WebKit Commit Bot 2011-05-28 11:19:01 PDT
Comment on attachment 95260 [details]
Patch

Clearing flags on attachment: 95260

Committed r87618: <http://trac.webkit.org/changeset/87618>
Comment 4 WebKit Commit Bot 2011-05-28 11:19:06 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2011-05-28 11:37:06 PDT
The commit-queue encountered the following flaky tests while processing attachment 95260 [details]:

http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org)
The commit-queue is continuing to process your patch.
Comment 6 Adam Barth 2011-05-30 00:21:59 PDT
I'm sorry I had to roll out this patch.  It caused the following assert:

BrowserFocusTest.FocusOnReload: 
ASSERTION FAILED: m_cachedLinkResource.get() == resource
third_party/WebKit/Source/WebCore/html/HTMLLinkElement.cpp(461) : virtual void WebCore::HTMLLinkElement::notifyFinished(WebCore::CachedResource*)

http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28Views%20dbg%29%281%29/builds/952/steps/interactive_ui_tests/logs/FocusOnReload
Comment 7 Adam Barth 2011-05-30 08:51:40 PDT
Comment on attachment 95260 [details]
Patch

Actually, I was wrong.  It was a different patch that caused the problem.
Comment 8 Adam Barth 2011-05-30 10:05:41 PDT
Comment on attachment 95260 [details]
Patch

Clearing flags on attachment: 95260

Committed r87691: <http://trac.webkit.org/changeset/87691>
Comment 9 Adam Barth 2011-05-30 10:05:45 PDT
All reviewed patches have been landed.  Closing bug.