prevent HTMLLinkElement from watching multiple CachedResources
Created attachment 95260 [details] Patch
Comment on attachment 95260 [details] Patch This is a nasty bug that causes a lot of crashes in chromium; thanks to Ziga Mahkovec <ziga@google.com> for making a really good reproduction (I was chasing this bug, without success, for a while before he gave me that), and to Chris Bentzel <cbentzel@chromium.org> for making a first draft at a fix!
Comment on attachment 95260 [details] Patch Clearing flags on attachment: 95260 Committed r87618: <http://trac.webkit.org/changeset/87618>
All reviewed patches have been landed. Closing bug.
The commit-queue encountered the following flaky tests while processing attachment 95260 [details]: http/tests/websocket/tests/multiple-connections.html bug 53825 (author: abarth@webkit.org) The commit-queue is continuing to process your patch.
I'm sorry I had to roll out this patch. It caused the following assert: BrowserFocusTest.FocusOnReload: ASSERTION FAILED: m_cachedLinkResource.get() == resource third_party/WebKit/Source/WebCore/html/HTMLLinkElement.cpp(461) : virtual void WebCore::HTMLLinkElement::notifyFinished(WebCore::CachedResource*) http://build.chromium.org/p/chromium/builders/Linux%20Tests%20%28Views%20dbg%29%281%29/builds/952/steps/interactive_ui_tests/logs/FocusOnReload
Comment on attachment 95260 [details] Patch Actually, I was wrong. It was a different patch that caused the problem.
Comment on attachment 95260 [details] Patch Clearing flags on attachment: 95260 Committed r87691: <http://trac.webkit.org/changeset/87691>