Bug 61671 – Convert shadow DOM-related tests to use window.internals.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

Convert shadow DOM-related tests to use window.internals.

[Dimitri Glazkov (Google)]

Created attachment 95222 [details]
Patch

[Dimitri Glazkov (Google)]

This seems like a good first start for window.internals. Love the tiny bit of code that will replace all that plumbing across ports. And the exports seems to be one-time deal, associated with setting a property callback on a JS wrapper.

[Dominic Cooney]

Comment on attachment 95222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=95222&action=review

> Source/WebCore/testing/Internals.cpp:51
> +

Nit: delete this blank line

[Dominic Cooney]

Yes—awesome.

[Dominic Cooney]

Created attachment 96922 [details]
WIP a patch towards the same goal for win and win-wk2

Now to update and unify these...

[Dominic Cooney]

Created attachment 96924 [details]
WIP a patch towards the same goal for win and win-wk2

More test updates.

[Dimitri Glazkov (Google)]

Freakish stuff. Keep up the good work!

[Dominic Cooney]

Created attachment 97054 [details]
WIP works on mac, mac-wk2 as well as win, win-wk2 (probably); rips out layoutTestController.*shadow* from various ports

This is based on attachment 96938 [details]. So I’m going to upload a megapatch including that to bounce off the build bots. I expect GTK and Qt need some love, so they are next.

[Dominic Cooney]

Created attachment 97055 [details]
Die code, die (which is German for "The code, the.")

Combines the patch on bug 61073 and attachment 97054 [details], for bouncing off bots.

[WebKit Review Bot]

Comment on attachment 97055 [details]
Die code, die (which is German for "The code, the.")

Attachment 97055 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8836477

New failing tests:
media/video-controls-in-media-document.html
fast/dom/HTMLKeygenElement/keygen.html

[WebKit Review Bot]

Created attachment 97057 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Gustavo Noronha (kov)]

Comment on attachment 97055 [details]
Die code, die (which is German for "The code, the.")

Attachment 97055 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/8832724

[Dominic Cooney]

Note to self: bug 61071 points to where GTK lists its WebCore exports for WebCoreTestSupport—Source/autotools/symbols.filter

[Dominic Cooney]

Created attachment 97106 [details]
Patch

I fixed GTK. Qt just works. I broke win/win-wk2 when I made internals methods throw exceptions if given bad arguments; I expect I fixed this but will verify. I updated the failing tests the Chromium Linux bot unearthed.

I think this is ready for human consumption. It is just blocked on bug 61073. In the meantime I will upload an omnibus patch including 61073 for the bots.

[Dominic Cooney]

Created attachment 97108 [details]
Moods for moderns|bots

This bug is blocked on 61073. This is attachment 97065 [details] from bug 61073 plus attachment 97106 [details], designed for the entrancement of bots.

[WebKit Review Bot]

Comment on attachment 97108 [details]
Moods for moderns|bots

Attachment 97108 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8843197

New failing tests:
fast/dom/HTMLKeygenElement/keygen.html

[WebKit Review Bot]

Created attachment 97112 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dominic Cooney]

Created attachment 97113 [details]
Patch

Another try. Forgot to squash a commit.

[Dominic Cooney]

Created attachment 97114 [details]
For bots

[Dominic Cooney]

Created attachment 98454 [details]
Patch

[WebKit Review Bot]

Comment on attachment 98454 [details]
Patch

Attachment 98454 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8939226

New failing tests:
fast/dom/shadow/create-content-element.html

[WebKit Review Bot]

Created attachment 98457 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Dominic Cooney]

Created attachment 98474 [details]
Patch

[WebKit Review Bot]

Comment on attachment 98474 [details]
Patch

Clearing flags on attachment: 98474

Committed r89682: <http://trac.webkit.org/changeset/89682>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.