Bug 59081 - Windows DRT needs an implementation of shadowRoot
Summary: Windows DRT needs an implementation of shadowRoot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Windows 7
: P2 Normal
Assignee: Dominic Cooney
URL:
Keywords: LayoutTestFailure, PlatformOnly
Depends on: 61671
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-21 00:41 PDT by Yuta Kitamura
Modified: 2011-06-24 11:45 PDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-04-21 00:41:22 PDT
Since r84472 (bug 59058), fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows.
Comment 1 Yuta Kitamura 2011-04-21 00:45:59 PDT
Committed r84476: <http://trac.webkit.org/changeset/84476>
Comment 2 Yuta Kitamura 2011-04-21 00:47:01 PDT
Ooh, it's not fixed yet :) Fixing the status.
Comment 3 Yuta Kitamura 2011-04-21 00:48:39 PDT
Test results (http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r84472%20(27888)/fast/dom/shadow/layout-tests-can-access-shadow-diffs.txt)


--- /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-expected.txt	2011-04-21 23:56:11.531250000 -0700
+++ /home/buildbot/slave/win-debug-tests/build/layout-test-results/fast/dom/shadow/layout-tests-can-access-shadow-actual.txt	2011-04-21 23:56:11.531250000 -0700
@@ -1,12 +1,12 @@
 
 This tests that LayoutTestController can access shadow DOM.
 
-PASS shadow.nodeName is "#shadow-root"
-PASS layoutTestController.shadowRoot(shadow) is null
-PASS layoutTestController.shadowRoot(p) is null
-PASS shadow.nodeName is "#shadow-root"
+FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName')
+FAIL layoutTestController.shadowRoot(shadow) should be null (of type object). Was undefined (of type undefined).
+FAIL layoutTestController.shadowRoot(p) should be null (of type object). Was undefined (of type undefined).
+FAIL shadow.nodeName should be #shadow-root. Threw exception TypeError: 'undefined' is not an object (evaluating 'shadow.nodeName')
 PASS shadow === layoutTestController.shadowRoot(p) is true
-PASS layoutTestController.shadowRoot(keygen) is null
+FAIL layoutTestController.shadowRoot(keygen) should be null (of type object). Was undefined (of type undefined).
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 4 Roland Steiner 2011-04-21 11:52:06 PDT
Same goes for fast/dom/shadow/nodetype.html
Comment 5 Roland Steiner 2011-04-21 12:02:04 PDT
Committed r84533: <http://trac.webkit.org/changeset/84533>
Comment 6 Philippe Normand 2011-05-06 02:18:26 PDT
Skipped media/video-controls-visible-audio-only.html too as a consequence of ttp://trac.webkit.org/changeset/85934
Comment 7 Dominic Cooney 2011-06-13 19:31:32 PDT
It does not make sense to implement layoutTestController.shadowRoot/ensureShadowRoot/removeShadowRoot/shadowPseudoId, because those methods are moving to window.internals per bug 61671. So the win DRT implementation of shadowRoot and friends is blocked on that.
Comment 8 Dominic Cooney 2011-06-24 11:45:22 PDT
Fixed in r89682. Windows tests can use internals.shadowRoot, ensureShadowRoot, shadowPseudoId, etc. and the mentioned tests were unskipped in that revision.