Bug 61290 - [Qt][V8] REGRESSION (r87063): Fix the build.
Summary: [Qt][V8] REGRESSION (r87063): Fix the build.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Andras Becsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-23 10:23 PDT by Andras Becsi
Modified: 2011-05-24 02:06 PDT (History)
4 users (show)

See Also:

Attachments
proposed fix (1.76 KB, patch)
2011-05-23 10:40 PDT, Andras Becsi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-05-23 10:23:06 PDT 
QtScript's shipped version of V8 is older than V8's r7923, so MarkIndependent() call needs to be disabled for now.
Comment 1 Andras Becsi 2011-05-23 10:40:12 PDT 
Created attachment 94441 [details]
proposed fix
Comment 2 Andras Becsi 2011-05-23 10:42:50 PDT 
(In reply to comment #0)
> QtScript's shipped version of V8 is older than V8's r7923, so MarkIndependent() call needs to be disabled for now.

We shouldn't forget to re-enable the call as soon as our V8 gets updated.
Comment 3 Andras Becsi 2011-05-23 10:43:32 PDT 
(In reply to comment #2)
> (In reply to comment #0)
> > QtScript's shipped version of V8 is older than V8's r7923, so MarkIndependent() call needs to be disabled for now.
> 
> We shouldn't forget to re-enable the call as soon as our V8 gets updated.
https://bugs.webkit.org/show_bug.cgi?id=61291
Comment 4 Csaba Osztrogonác 2011-05-24 02:02:11 PDT 
Comment on attachment 94441 [details]
proposed fix

r=me
Comment 5 Andras Becsi 2011-05-24 02:06:11 PDT 
(In reply to comment #4)
> (From update of attachment 94441 [details])
> r=me

Thanks!

Committed r87138
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
Comment 6 Andras Becsi 2011-05-24 02:06:43 PDT 
Comment on attachment 94441 [details]
proposed fix

Clearing flags.