Bug 61291 - [Qt][V8] Enable marking objects with complex GC rules
Summary: [Qt][V8] Enable marking objects with complex GC rules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-23 10:31 PDT by Andras Becsi
Modified: 2011-06-21 08:59 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (1.64 KB, patch)
2011-06-21 08:17 PDT, Peter Varga
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.30 MB, application/zip)
2011-06-21 08:39 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2011-05-23 10:31:58 PDT
Enable the MarkIndependent() call in Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:2556
Comment 1 Peter Varga 2011-06-21 08:17:58 PDT
Created attachment 97990 [details]
proposed patch

The QtScript's V8 is up-to-date now. We can enable this functionality.
Comment 2 Andreas Kling 2011-06-21 08:20:16 PDT
Comment on attachment 97990 [details]
proposed patch

rs=me, but please rebaseline run-bindings-tests when landing.
Comment 3 WebKit Review Bot 2011-06-21 08:39:11 PDT
Comment on attachment 97990 [details]
proposed patch

Attachment 97990 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8912908
Comment 4 WebKit Review Bot 2011-06-21 08:39:16 PDT
Created attachment 97992 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Peter Varga 2011-06-21 08:59:08 PDT
Committed r89358: <http://trac.webkit.org/changeset/89358>