Bug 61229 – REGRESSION (r70748): WebKit cannot play QuickTime movies on Mac OS X Wiki Server pages

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

WebKit cannot play videos created by Podcast Producer.

[Andy Estes]

<rdar://problem/9440255>

[Andy Estes]

Created attachment 94301 [details]
Patch

[Darin Adler]

Comment on attachment 94301 [details]
Patch

It’s unfortunate that we need a rule that is not the same as what’s in HTML5. We should raise this issue with the HTML5 folks.

[Andy Estes]

Committed r87007: <http://trac.webkit.org/changeset/87007>

[Ademar Reis]

Revision r87007 cherry-picked into qtwebkit-2.2 with commit c6d8071 <http://gitorious.org/webkit/qtwebkit/commit/c6d8071>

[Andy Estes]

In the process of drafting an email to whatwg I convinced myself that this is the wrong approach to take. By permitting object elements with classids, we can end up loading content meant for an ActiveX component in a Netscape plug-in in certain circumstances (e.g. the url happens to have a file extension that a Netscape plug-in claims to support). Preventing a plug-in from loading content not meant for it is the rationale behind falling back for non-empty classids (even falling back to nothing). I don't think we should allow this to happen in general just because we happen to know that doing so is safe for this one case.

I think a better approach for this case is to restore QuickTime's classid mapping (perhaps even wrapped with a site-specific hacks runtime guard). It seems safer to specifically permit loading QuickTime in this manner (under the assumption that content loadable in the QuickTime ActiveX component is also loadable in the NPAPI plug-in).

[Andy Estes]

Created attachment 94714 [details]
Patch

[Geoffrey Garen]

Comment on attachment 94714 [details]
Patch

r=me

[Jeff Miller]

Comment on attachment 94714 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=94714&action=review

> Source/WebCore/html/HTMLObjectElement.cpp:250
> +    if (!document()->page()

Is this a problem with Mac OS X Wiki Server, or with Podcast Producer specifically?

[Andy Estes]

(In reply to comment #9)
> (From update of attachment 94714 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94714&action=review
> 
> > Source/WebCore/html/HTMLObjectElement.cpp:250
> > +    if (!document()->page()
> 
> Is this a problem with Mac OS X Wiki Server, or with Podcast Producer specifically?

It's a problem with any QuickTime movie hosted by Wiki Server.

[Andy Estes]

Committed r87244: <http://trac.webkit.org/changeset/87244>

[Ademar Reis]

Revision r87244 cherry-picked into qtwebkit-2.2 with commit f8d4988 <http://gitorious.org/webkit/qtwebkit/commit/f8d4988>

[Ryosuke Niwa]

I think we can remove this quirk now since OS X Sever shipped with Mountain Lion and later has been emitting video element as fallback.