Bug 195607 – Remove OS X Server QuickTime plugin quirks

• Status: RESOLVED
• Resolution: FIXED
• Component: Plug-ins

[Ryosuke Niwa]

https://trac.webkit.org/r87244 added a site specific quirk for Mac OS X Sever wiki pages.
However, the issue has since been resolved as of OS X Mountain Lion.

Apple has ended the support of this operating system in September 2015,
and iTunes' support subsequently ended in August 2016.

Furthermore, the latest versions of Safari no longer supports non-Flash plugins.

So the only scenario in which this code will be triggered is with custom WKWebView / WebKitLegacy app
which loads OS X Server pages running OS X Mountain Lion or earlier.

Given these, I think we can remove this site specific quirk.

[Brent Fulgham]

Do it!

[Ryosuke Niwa]

Created attachment 364355 [details]
Cleanup

[Brent Fulgham]

Comment on attachment 364355 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=364355&action=review

Nice! I find all of this code removal to be cathartic!

> Source/WebCore/ChangeLog:9
> +	However, the issue has since been resolved as of OS X Mountain Lion,

Weird white spacing on this line.

> Source/WebCore/ChangeLog:13
> +        the only scenario in which this quirk come into play is when a third party app

“comes into play”

[EWS Watchlist]

Attachment 364355 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ryosuke Niwa]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 364355 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364355&action=review
> 
> Nice! I find all of this code removal to be cathartic!
> 
> > Source/WebCore/ChangeLog:9
> > +	However, the issue has since been resolved as of OS X Mountain Lion,
> 
> Weird white spacing on this line.

Fixed.

> > Source/WebCore/ChangeLog:13
> > +        the only scenario in which this quirk come into play is when a third party app
> 
> “comes into play”

Fixed.

[Ryosuke Niwa]

For those at Apple, also see <rdar://problem/9489557>.

[Ryosuke Niwa]

Committed r242784: <https://trac.webkit.org/changeset/242784>

[Radar WebKit Bug Importer]

<rdar://problem/48799810>