Bug 60945 – WebSocket: Uninline methods in ThreadableWebSocketChannelClientWrapper

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Yuta Kitamura]

This is the second part of implementing WebSocket closing handshake (see bug 35721).

Add ThreadableWebSocketChannelClietWrapper.cpp. Uninline methods in this class and move these definitions into .cpp in order to allow further modifications in this class.

[Yuta Kitamura]

Created attachment 93743 [details]
Patch

[Kent Tamura]

Comment on attachment 93743 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=93743&action=review

Looks ok.

> Source/WebCore/websockets/ThreadableWebSocketChannelClientWrapper.cpp:35
> +#include "config.h"
> +
> +#if ENABLE(WEB_SOCKETS)
> +
> +#include "ThreadableWebSocketChannelClientWrapper.h"

nit: Need no blank lines.

[Yuta Kitamura]

Created attachment 93749 [details]
Ready to commit

[Yuta Kitamura]

Created attachment 93750 [details]
Ready to commit

[Hajime Morrita]

Comment on attachment 93750 [details]
Ready to commit

cq+

[WebKit Commit Bot]

Comment on attachment 93750 [details]
Ready to commit

Rejecting attachment 93750 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1

Last 500 characters of output:
autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain
    result = func(*args)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open
    return self.do_open(conn_factory, req)
  File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open
    raise URLError(err)
urllib2.URLError: <urlopen error [Errno 60] Operation timed out>

Full output: http://queues.webkit.org/results/8705311

[Yuta Kitamura]

Hum? CQ failed but the patch has been landed in r86669.

Closing the issue...

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 93750 [details]:

http/tests/websocket/tests/url-with-query.html bug 60955 (author: [e-mail])
The commit-queue is continuing to process your patch.