Global object initialization is expensive
Created attachment 93713 [details] Patch
Attachment 93713 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/BooleanPrototype.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/ArrayConstructor.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/StringConstructor.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/RegExpPrototype.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/NumberPrototype.cpp:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/ErrorPrototype.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 93713 [details] Patch Attachment 93713 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8704145
Comment on attachment 93713 [details] Patch Attachment 93713 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8708075
Created attachment 93733 [details] Patch
New patch for the EWS bots to chew on.
Attachment 93733 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/BooleanPrototype.cpp:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/ArrayConstructor.cpp:40: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/StringConstructor.cpp:36: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/RegExpPrototype.cpp:48: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/NumberPrototype.cpp:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/ErrorPrototype.cpp:39: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 6 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 93733 [details] Patch Marking r+ to get this out of the review queue.
Committed r86653: <http://trac.webkit.org/changeset/86653>
Your change caused a lot of regressions on Windows bots: http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/28715 http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/12917 (And your change seems to be reviewed by yourself, which I don't know is the right thing to do.)
Other bots are also failing (EFL compile, Leopard/Snow Leopard tests), so I'm going to roll out this change.
Are we talking about a few nanoseconds per engine instance (ignoring worker threads for a moment), or about something significant?
Rollout patch has landed. I appreciate your understanding about keeping our bots green. Error details: Windows http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/28715 (Layout test crashes, jscore-test 962 failures) Leopard, SnowLeopard http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/29391 (Sputnik failures) EFL http://build.webkit.org/builders/EFL%20Linux%20Release%20%28Build%29/builds/14457 (Compile error)
Committed r86727: <http://trac.webkit.org/changeset/86727>
Looks like the EFL builder is broken. I filed https://bugs.webkit.org/show_bug.cgi?id=61018 to track that.